Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simbench fixes #443

Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix: simbench fixes #443

merged 2 commits into from
Feb 28, 2025

Conversation

MagdalenaKotynia
Copy link
Member

@MagdalenaKotynia MagdalenaKotynia commented Feb 28, 2025

Purpose

To fix issue with the wrong metrics results.

Proposed Changes

  • Fix of transpose missed after rebase and merge of test: rai_sim tests #437
  • Improved saving benchmark.log and results.log to not overwrite the previous logs and results.

Issues

#435 (comment)

Testing

Compared metrics results with visual observations

@MagdalenaKotynia MagdalenaKotynia marked this pull request as ready for review February 28, 2025 10:22
Copy link
Member

@maciejmajek maciejmajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejmajek maciejmajek merged commit 70e824f into feat/simbench Feb 28, 2025
2 checks passed
@maciejmajek maciejmajek deleted the fix/simbench-fixes branch February 28, 2025 11:24
maciejmajek pushed a commit that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants