Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve performance of O3DE Benchmark #442

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

jmatejcz
Copy link

Purpose

  • Improve performance of O3DE benchmark

Proposed Changes

reduce sleep times
move arm to more accessible position after every scenario

Issues

These changes reduce time of execution only slightly.
The most time consuming are LLM processing and tool calls

Testing

  1. Setup the repository
  2. Install dependencies listed in:
    https://github.com/RobotecAI/rai/blob/main/docs/demos/manipulation.md

and:

poetry install --with openset
colcon build --symlink-install
source setup_shell.sh
  1. Download GameLauncher binary: humble or jazzy

  2. Populate src/rai_bench/rai_bench/o3de_test_bench/configs/o3de_config.yaml with:

binary_path: /path/to/your/GameLauncher
robotic_stack_command: ros2 launch examples/manipulation-demo-no-binary.launch.py
required_services:
  - /grounding_dino_classify
  - /grounded_sam_segment
  - /manipulator_move_to
  - /spawn_entity
  - /delete_entity
required_topics:
  - /color_image5
  - /depth_image5
  - /color_camera_info5
required_actions: []
  1. Run the benchmark
python src/rai_bench/rai_bench/examples/o3de_test_benchmark.py
  1. What to look for:
  • If simulation starts
  • If arm is moved to the correct position after each scenario(top right corner of the table)

@jmatejcz jmatejcz requested a review from maciejmajek February 27, 2025 15:02
@jmatejcz jmatejcz force-pushed the jm/feat/rai_bench_performance_improve branch from 14d4567 to ffa39dc Compare February 28, 2025 08:20
@jmatejcz jmatejcz marked this pull request as ready for review February 28, 2025 10:06
@jmatejcz jmatejcz force-pushed the jm/feat/rai_bench_performance_improve branch from ffa39dc to b6446ee Compare February 28, 2025 11:29
Copy link
Member

@maciejmajek maciejmajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejmajek maciejmajek merged commit e7527b5 into feat/simbench Feb 28, 2025
2 checks passed
@maciejmajek maciejmajek deleted the jm/feat/rai_bench_performance_improve branch February 28, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants