Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple shells in the setup script #216

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

rachwalk
Copy link
Contributor

@rachwalk rachwalk commented Sep 10, 2024

Purpose

While bash is the most popular shell by far, many users prefer to use zsh on their setups for improved interactivity. ROS2 supports setup scripts for bash, zsh, and sh so RAI should provide users with ability to set up either of the three out of the box.

Proposed Changes

Adds support multiple shells in the setup script

Issues

N/A

Testing

the script has been tested by the following procedure:

chsh [shell_name]
source ./setup_shell.sh
echo $PYTHON_PATH

The setup has worked correctly for bash, zsh, and sh.

@maciejmajek maciejmajek merged commit 5e8360f into development Sep 11, 2024
4 checks passed
@maciejmajek maciejmajek deleted the kr/update-setup-script branch September 11, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants