Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1888] Move RGTestUtils into its own test assembly #243

Merged
merged 2 commits into from
Aug 6, 2024
Merged

[REG-1888] Move RGTestUtils into its own test assembly #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7fe307
move RGTestUtils into its own test assembly
svolokh Aug 5, 2024
d5e04e0
fix standalone compile error
svolokh Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/RGUnityBots/Assets/Tests/Runtime/RegressionGames.Tests.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
],
"references": [
"RegressionGames",
"RegressionGames.TestFramework",
"Unity.InputSystem",
"Unity.InputSystem.TestFramework"
],
Expand Down
3 changes: 2 additions & 1 deletion src/gg.regression.unity.bots/Editor/Scripts/RGEditorUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
using System;
using System.IO;
using RegressionGames.StateRecorder;
using UnityEditor.Compilation;

#if UNITY_EDITOR
using UnityEditor;
using UnityEditor.Compilation;
#endif

namespace RegressionGames.Editor
Expand Down
3 changes: 3 additions & 0 deletions src/gg.regression.unity.bots/Tests.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/gg.regression.unity.bots/Tests/TestFramework.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/gg.regression.unity.bots/Tests/TestFramework/Scripts.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...unity.bots/Runtime/Scripts/RGTestUtils.cs → ...ests/TestFramework/Scripts/RGTestUtils.cs
View file
Open in desktop
File renamed without changes.
0 ....bots/Runtime/Scripts/RGTestUtils.cs.meta → ...TestFramework/Scripts/RGTestUtils.cs.meta
View file
Open in desktop
File renamed without changes.
16 changes: 16 additions & 0 deletions ...gg.regression.unity.bots/Tests/TestFramework/Scripts/RegressionGames.TestFramework.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"name": "RegressionGames.TestFramework",
"references": [
"RegressionGames",
"UnityEngine.TestRunner",
"UnityEditor.TestRunner"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this UnityEditor reference work when we run our build tests in docker ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can see it passing in this PR as well above. I also verified that the tests work when run in standalone mode. It is standard for both play mode and edit mode tests to refer to both the UnityEngine.TestRunner and UnityEditor.TestRunner assemblies (this is the same practice employed by other test framwork libraries too, such as InputSystem.TestFramework).

],
"includePlatforms": [],
"excludePlatforms": [],
"allowUnsafeCode": true,
"overrideReferences": true,
"precompiledReferences": [
"nunit.framework.dll"
],
"autoReferenced": false
}
3 changes: 3 additions & 0 deletions ...gression.unity.bots/Tests/TestFramework/Scripts/RegressionGames.TestFramework.asmdef.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading