[REG-1888] Move RGTestUtils into its own test assembly #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nAmKcAz
approved these changes
Aug 6, 2024
| "references": [ | ||
| "RegressionGames", | ||
| "UnityEngine.TestRunner", | ||
| "UnityEditor.TestRunner" |
There was a problem hiding this comment.
Does this UnityEditor reference work when we run our build tests in docker ?
There was a problem hiding this comment.
Yes, you can see it passing in this PR as well above. I also verified that the tests work when run in standalone mode. It is standard for both play mode and edit mode tests to refer to both the UnityEngine.TestRunner and UnityEditor.TestRunner assemblies (this is the same practice employed by other test framwork libraries too, such as InputSystem.TestFramework).
abeizer
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move RGTestUtils into its own test assembly
RegressionGames.TestFramework. Unity Test Runner assemblies should now reference this assembly to use the SDK's test utilities.This change is a follow-up to a previous discussion (#236 (comment)) about separating the test code from the runtime SDK code. Separating into a different assembly gives us access to the test-only APIs (e.g. NUnit) so we can build/extend on these in the future if desired.
Associated PRs:
https://github.com/Regression-Games/RGBossRoom/pull/62
Regression-Games/RegressionDocs#80