Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/discord image #84

Closed
wants to merge 2 commits into from
Closed

Fix/discord image #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4114435
fix(ci.yml): reintroduce environment variables for build step
charlottewiltshire0 Feb 9, 2025
00f4a5c
chore: update Discord image URL to new invite link
charlottewiltshire0 Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# See https://github.com/actions/labeler

translation:
- locales/**
translation: locales/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: The translation path syntax was simplified from array to direct path format. Both work, but be consistent across the config.


feature:
- head-branch: ['^feature', 'feature']
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ jobs:
run: bun run build
env:
NEXT_PUBLIC_GTM_ID: ${{ secrets.NEXT_PUBLIC_GTM_ID }}
NEXT_PUBLIC_SANITY_PROJECT_ID: ${{ secrets.NEXT_PUBLIC_SANITY_PROJECT_ID }}
NEXT_PUBLIC_SANITY_DATASET: ${{ secrets.NEXT_PUBLIC_SANITY_DATASET }}
NEXT_PUBLIC_BASE_URL: ${{ secrets.NEXT_PUBLIC_BASE_URL }}
NEXT_PUBLIC_SANITY_PROJECT_ID: qqvmmpgb
NEXT_PUBLIC_SANITY_DATASET: test
NEXT_PUBLIC_BASE_URL: https://www.redotengine.org
Comment on lines +51 to +53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Hardcoding sensitive configuration values like Sanity credentials directly in the workflow file is a security risk. These should remain as secrets to allow for proper environment management and security.

Suggested change
NEXT_PUBLIC_SANITY_PROJECT_ID: qqvmmpgb
NEXT_PUBLIC_SANITY_DATASET: test
NEXT_PUBLIC_BASE_URL: https://www.redotengine.org
NEXT_PUBLIC_SANITY_PROJECT_ID: ${{ secrets.NEXT_PUBLIC_SANITY_PROJECT_ID }}
NEXT_PUBLIC_SANITY_DATASET: ${{ secrets.NEXT_PUBLIC_SANITY_DATASET }}
NEXT_PUBLIC_BASE_URL: ${{ secrets.NEXT_PUBLIC_BASE_URL }}

Binary file modified bun.lockb
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion constants/socials.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const communityLinks: CommunityCardProps[] = [

export const communitySpaces: CommunityCardProps[] = [
{
imageUrl: "https://image.redotengine.org/socials/discord.png",
imageUrl: "https://image.redotengine.org/socials/discordInvite.webp",
label: "Discord (Invite)",
description: "communitySpacesLinks.discord",
href: socialsLinks.discord,
Expand Down
Loading