Fix/discord image #84
Conversation
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates image formats, CI workflow configurations, and labeler settings across the Redot Engine website repository.
- Changed Discord invite image from PNG to WebP format in
/constants/socials.tsxfor improved performance - Hardcoded sensitive environment variables in
/.github/workflows/ci.ymlwhich could pose security concerns - Added feature branch auto-labeling in
/.github/labeler.ymlfor branches starting with or matching 'feature' - Simplified translation path syntax in labeler configuration for better maintainability
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| NEXT_PUBLIC_SANITY_PROJECT_ID: qqvmmpgb | ||
| NEXT_PUBLIC_SANITY_DATASET: test | ||
| NEXT_PUBLIC_BASE_URL: https://www.redotengine.org |
There was a problem hiding this comment.
logic: Hardcoding sensitive configuration values like Sanity credentials directly in the workflow file is a security risk. These should remain as secrets to allow for proper environment management and security.
| NEXT_PUBLIC_SANITY_PROJECT_ID: qqvmmpgb | |
| NEXT_PUBLIC_SANITY_DATASET: test | |
| NEXT_PUBLIC_BASE_URL: https://www.redotengine.org | |
| NEXT_PUBLIC_SANITY_PROJECT_ID: ${{ secrets.NEXT_PUBLIC_SANITY_PROJECT_ID }} | |
| NEXT_PUBLIC_SANITY_DATASET: ${{ secrets.NEXT_PUBLIC_SANITY_DATASET }} | |
| NEXT_PUBLIC_BASE_URL: ${{ secrets.NEXT_PUBLIC_BASE_URL }} |
| @@ -1,4 +1,6 @@ | |||
| # See https://github.com/actions/labeler | |||
|
|
|||
| translation: | |||
| - locales/** | |||
| translation: locales/** | |||
There was a problem hiding this comment.
style: The translation path syntax was simplified from array to direct path format. Both work, but be consistent across the config.
PR Content: