Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Tests] remove workaround for test_conv_for_implicit_gemm from #240 (#1167) #1170

Closed
wants to merge 6 commits into from
Closed

[CI][Tests] remove workaround for test_conv_for_implicit_gemm from #240 (#1167) #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2e7e72
fix #1167: revert WA from #240
junliume Sep 22, 2021
b9330ba
Merge branch 'develop' into fix_#1167
junliume Oct 15, 2021
b6ba14d
attempt for ##1181
junliume Oct 15, 2021
924ff15
attempt for #1180
junliume Oct 15, 2021
f7f7ccd
remove W/A mentioned in #1177
junliume Oct 15, 2021
447b725
Revert "fix-jenkins-failures(03) [test_sqlite_perfdb] Reduce amount o…
junliume Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_AR
COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_ARGS} --verbose --input 16 64 56 56 --weights 64 64 1 1 --pads_strides_dilations 0 0 1 1 1 1 | grep -v "cannot be executed due to incorrect params"
COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_ARGS} --verbose --input 16 128 55 55 --weights 16 128 1 1 --pads_strides_dilations 0 0 1 1 1 1 | grep -v "cannot be executed due to incorrect params"
COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_ARGS} --verbose --input 16 128 28 28 --weights 16 128 1 1 --pads_strides_dilations 0 0 1 1 1 1 | grep -v "cannot be executed due to incorrect params"
# COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_ARGS} --verbose --input 16 128 14 14 --weights 16 128 1 1 --pads_strides_dilations 0 0 1 1 1 1
COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_ARGS} --verbose --input 16 128 14 14 --weights 16 128 1 1 --pads_strides_dilations 0 0 1 1 1 1 | grep -v "cannot be executed due to incorrect params"
COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_ARGS} --verbose --input 16 128 7 7 --weights 16 128 1 1 --pads_strides_dilations 0 0 1 1 1 1 | grep -v "cannot be executed due to incorrect params"
COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_ARGS} --verbose --input 64 128 55 55 --weights 16 128 1 1 --pads_strides_dilations 0 0 2 2 1 1 | grep -v "cannot be executed due to incorrect params"
COMMAND ${IMPLICITGEMM_TESTING_ENV} $<TARGET_FILE:test_conv2d> ${IMPLICITGEMM_ARGS} --verbose --input 64 128 28 28 --weights 16 128 1 1 --pads_strides_dilations 0 0 2 2 1 1 | grep -v "cannot be executed due to incorrect params"
Expand Down Expand Up @@ -811,8 +811,7 @@ COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 16 1024 7 7 --weights 2048
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 32 128 56 56 --weights 256 4 3 3 --pads_strides_dilations 1 1 1 1 1 1 --group-count 32
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 32 256 56 56 --weights 512 8 3 3 --pads_strides_dilations 1 1 2 2 1 1 --group-count 32
#
# Workaround for "Memory access fault by GPU node" during "HIP Release All" - WrW disabled.
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 32 256 28 28 --weights 512 8 3 3 --pads_strides_dilations 1 1 1 1 1 1 --group-count 32 --disable-backward-weights
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 32 256 28 28 --weights 512 8 3 3 --pads_strides_dilations 1 1 1 1 1 1 --group-count 32
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 32 512 28 28 --weights 1024 16 3 3 --pads_strides_dilations 1 1 2 2 1 1 --group-count 32
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 32 512 14 14 --weights 1024 16 3 3 --pads_strides_dilations 1 1 1 1 1 1 --group-count 32
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 32 1024 14 14 --weights 2048 32 3 3 --pads_strides_dilations 1 1 2 2 1 1 --group-count 32
Expand All @@ -836,8 +835,7 @@ COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 8 3 224 224 --weights 63 1
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 8 64 112 112 --weights 128 32 3 3 --pads_strides_dilations 1 1 1 1 1 1 --group-count 2
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 16 9 224 224 --weights 63 3 3 3 --pads_strides_dilations 1 1 1 1 1 1 --group-count 3
#
# Workaround for "Memory access fault by GPU node" during "FP32 gfx908 Hip Release All subset" - WrW disabled.
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 16 64 112 112 --weights 128 16 3 3 --pads_strides_dilations 1 1 1 1 1 1 --group-count 4 --disable-backward-weights
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 16 64 112 112 --weights 128 16 3 3 --pads_strides_dilations 1 1 1 1 1 1 --group-count 4
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 16 3 224 224 --weights 63 1 7 7 --pads_strides_dilations 3 3 2 2 1 1 --group-count 3
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 16 192 28 28 --weights 32 12 5 5 --pads_strides_dilations 2 2 1 1 1 1 --group-count 16
COMMAND $<TARGET_FILE:test_conv2d> --verbose --input 16 832 7 7 --weights 128 52 5 5 --pads_strides_dilations 2 2 1 1 1 1 --group-count 16
Expand Down
5 changes: 0 additions & 5 deletions test/ctc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,11 +707,6 @@ struct ctc_driver : test_driver
if(type != miopenFloat)
return;

/// \todo Resolve the issue and remove workaround.
/// The matching test cases fail on Jenkins from time to time.
if(numClass == 5000 && is_softmax_applied)
return;

ctcLossDesc.dataType = miopenFloat;
ctcLossDesc.apply_softmax_layer = is_softmax_applied;
ctcLossDesc.blank_label_id = blank_id;
Expand Down
6 changes: 0 additions & 6 deletions test/rnn_vanilla_common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2622,11 +2622,6 @@ struct rnn_basic_vanilla_driver : test_driver
seqLength, numLayers, biasMode, dirMode, inputMode,
rnnMode, inVecReal, hx_sz, nohx, bool(useDropout)});

/// \todo Resolve the issue and remove workaround.
/// ROCm3.3, Radeon VII: Many test cases always fail with:
/// "Forward Inference RNN vanilla:"
/// "Output tensor output failed verification."
#if 0
if(useDropout == 0)
{
verify(verify_forward_infer_rnn<T>{rnnDesc,
Expand All @@ -2647,7 +2642,6 @@ struct rnn_basic_vanilla_driver : test_driver
nohx,
nohy});
}
#endif
/* normal hx/cx/dhy/dcy input test end */

// DLOWELL: This part may produce NAN and infinities. Further investigation is needed.
Expand Down
16 changes: 10 additions & 6 deletions test/sqlite_perfdb.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,9 +721,9 @@ class DBMultiThreadedTestWork
// NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
unsigned int DBMultiThreadedTestWork::threads_count = 16;
// NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
unsigned int DBMultiThreadedTestWork::common_part_size = 16;
unsigned int DBMultiThreadedTestWork::common_part_size = 32;
// NOLINTNEXTLINE (cppcoreguidelines-avoid-non-const-global-variables)
unsigned int DBMultiThreadedTestWork::unique_part_size = 16;
unsigned int DBMultiThreadedTestWork::unique_part_size = 32;

class DbMultiThreadedTest : public DbTest
{
Expand Down Expand Up @@ -1242,10 +1242,14 @@ struct PerfDbDriver : test_driver

if(full_set)
{
tests::full_set() = true;
DBMultiThreadedTestWork::threads_count = 16;
DBMultiThreadedTestWork::common_part_size = 32;
DBMultiThreadedTestWork::unique_part_size = 32;
tests::full_set() = true;
#if MIOPEN_BACKEND_HIP
DBMultiThreadedTestWork::threads_count = 20;
#else
DBMultiThreadedTestWork::threads_count = 64;
#endif
DBMultiThreadedTestWork::common_part_size = 64;
DBMultiThreadedTestWork::unique_part_size = 64;
}
if(mt_child_id >= 0)
{
Expand Down