Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Tests] remove workaround for test_conv_for_implicit_gemm from #240 (#1167) #1170

Closed
wants to merge 6 commits into from

Conversation

junliume
Copy link
Contributor

@junliume junliume commented Sep 23, 2021

ref: #1167
re-enabling it seems to be stable in the tip of develop

This PR is a housekeeping mini-maintenance suggested by Artem

@junliume
Copy link
Contributor Author

@atamazov please review. a very small step towards your goal of resolving the W/As :)

@atamazov
Copy link
Contributor

atamazov commented Sep 25, 2021

@junliume Thanks! unfortunately there is WORKAROUND_ISSUE_936 which seems terribly excessive and may mask Fwd/Bwd FP16 issues (possibly uncovered by this PR):
https://github.com/ROCmSoftwarePlatform/MIOpen/blob/030a3695d5f899afbd484338558fbb70a4b204d1/test/CMakeLists.txt#L693

Let's rework that workaround first (I am working on it with @shurale-nkn)

@junliume
Copy link
Contributor Author

@junliume Thanks! unfortunately there is WORKAROUND_ISSUE_936 which seems terribly excessive and may mask Fwd/Bwd FP16 issues (possibly uncovered by this PR):
https://github.com/ROCmSoftwarePlatform/MIOpen/blob/030a3695d5f899afbd484338558fbb70a4b204d1/test/CMakeLists.txt#L693

Let's rework that workaround first (I am working on it with @shurale-nkn)

Thanks! Let's keep this PR On Hold then.

@junliume junliume marked this pull request as draft September 26, 2021 04:50
@codecov

This comment has been minimized.

@atamazov
Copy link
Contributor

I recommend holding this off until my work with wa-936-cleanup (no PR yet) is done. Unfortunately I am totally busy with hiprtc right now...

@junliume
Copy link
Contributor Author

I recommend holding this off until my work with wa-936-cleanup (no PR yet) is done. Unfortunately I am totally busy with hiprtc right now...

Sure! That's why it is still in draft phase, I am reverting a few of these W/As and use quiet time of CI systems to observe if there are any issues. :)

@junliume junliume closed this Dec 13, 2021
@junliume junliume deleted the fix_#1167 branch January 7, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants