Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite main CI/CD into a single workflow #34

Merged
merged 5 commits into from
Dec 22, 2024
Merged

Rewrite main CI/CD into a single workflow #34

merged 5 commits into from
Dec 22, 2024

Conversation

RandomSpaceship
Copy link
Contributor

Fixes permanently pending checks on PRs, fixing #32. Need to investigate #33 before merging, may as well make it all one PR.

@RandomSpaceship
ci-cd: Rewrite GH Actions
e9eb7fd 
- Now all integrated into one workflow
- intersphinx update runs on cron job instead of push
- Use `git-auto-commit-action` instead of manual setup and push
- Job execution order is now correct since they're all in the same workflow
@RandomSpaceship
ci-cd: Allow manual job triggers
9e6e0d7
@RandomSpaceship
ci-cd(filters): Run all jobs on filters update
b49087d
@RandomSpaceship RandomSpaceship linked an issue Dec 21, 2024 that may be closed by this pull request
Fix GH Actions required checks #32
Closed
@RandomSpaceship RandomSpaceship added 01-bug Something isn't working 26-ci/cd Involves the CI/CD toolchain labels Dec 21, 2024
@RandomSpaceship RandomSpaceship linked an issue Dec 22, 2024 that may be closed by this pull request
Investigate running GH Actions using a deployment environment #33
Closed
@RandomSpaceship RandomSpaceship marked this pull request as ready for review December 22, 2024 04:13
DingoOz
DingoOz reviewed Dec 22, 2024
View reviewed changes
Copy link
Contributor

@DingoOz DingoOz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, especially having all the jobs in into one workflow to achieve what we want it to

DingoOz
DingoOz reviewed Dec 22, 2024
View reviewed changes
Copy link
Contributor

@DingoOz DingoOz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done with the separate environments

DingoOz
DingoOz reviewed Dec 22, 2024
View reviewed changes
Copy link
Contributor

@DingoOz DingoOz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One badge to rule them all :)

DingoOz
DingoOz approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@DingoOz DingoOz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to have this working and all in one spot.

@RandomSpaceship RandomSpaceship added this pull request to the merge queue Dec 22, 2024
Merged via the queue into main with commit 95d7c60 Dec 22, 2024
10 checks passed
@RandomSpaceship RandomSpaceship deleted the actions-dev branch December 22, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DingoOz DingoOz DingoOz approved these changes

Assignees
No one assigned
Labels
01-bug Something isn't working 26-ci/cd Involves the CI/CD toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate running GH Actions using a deployment environment Fix GH Actions required checks
2 participants
@RandomSpaceship @DingoOz