Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing baseline by removing Espell and SpecDebugger dependencies #4

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Fixing baseline by removing Espell and SpecDebugger dependencies #4

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5040868
Fixing baseline dependencies by adding espell and removing SpecDebugger
adri09070 Sep 9, 2022
6831d98
Fixing baseline by removing Espell and SpecDebugger dependencies
adri09070 Sep 9, 2022
8e4b5c7
removing Ghost and the overlays from the baseline
adri09070 Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 19 additions & 22 deletions BaselineOfDebuggableASTInterpreter/BaselineOfDebuggableASTInterpreter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,24 @@ Class {
BaselineOfDebuggableASTInterpreter >> baseline: spec [

<baseline>
spec
for: #common
do: [
"Dependencies"
spec
baseline: 'SpecDebugger'
with: [ spec repository: 'github://dupriezt/Spec-Debugger' ].
spec
baseline: 'Ghost'
with: [ spec repository: 'gitlab://gitlab.inria.fr:RMOD/Ghost' ].

"Packages"
spec
package: 'DebuggableASTInterpreter';
package: 'DebuggableASTDebugger' with: [ spec requires: #('DebuggableASTInterpreter' 'SpecDebugger') ];
package: 'DebuggableASTInterpreterOverlays' with: [ spec requires: #('DebuggableASTDebugger' 'Ghost') ]].
spec for: #common do: [ "Dependencies"
spec
baseline: 'Ghost'
with: [ spec repository: 'gitlab://gitlab.inria.fr:RMOD/Ghost' ].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Ghost really needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I just left it because it is needed for an "experimental" package that I will never load anyway but I can delete the dependency and the package if you want

Copy link
Contributor Author

@adri09070 adri09070 Sep 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed Ghost and the overlay from the baseline. In this case, it would also fix #1


"Packages"
spec
package: 'DebuggableASTInterpreter';
package: 'DebuggableASTDebugger' with: [
spec requires: #( 'DebuggableASTInterpreter' ) ];
package: 'DebuggableASTInterpreterOverlays'
with: [ spec requires: #( 'DebuggableASTDebugger'
'Ghost' ) ] ].

"Groups"
spec
group: 'default' with: #('Model');
group: 'Model' with: #('DebuggableASTInterpreter');
group: 'Debugger' with: #('DebuggableASTDebugger');
group: 'Overlay' with: #('DebuggableASTInterpreterOverlays')
"Groups"
spec
group: 'default' with: #( 'Model' );
group: 'Model' with: #( 'DebuggableASTInterpreter' );
group: 'Debugger' with: #( 'DebuggableASTDebugger' );
group: 'Overlay' with: #( 'DebuggableASTInterpreterOverlays' )
]
29 changes: 0 additions & 29 deletions DebuggableASTDebugger/DASTEyeContextInspector.class.st
View file
Open in desktop

This file was deleted.

125 changes: 0 additions & 125 deletions DebuggableASTDebugger/DASTSpecDebugger.class.st
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions DebuggableASTDebugger/DASTSpecDebuggerStack.class.st
View file
Open in desktop

This file was deleted.

Loading