Fixing baseline by removing Espell and SpecDebugger dependencies #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep
requested changes
Sep 9, 2022
| spec for: #common do: [ "Dependencies" | ||
| spec | ||
| baseline: 'Ghost' | ||
| with: [ spec repository: 'gitlab://gitlab.inria.fr:RMOD/Ghost' ]. |
There was a problem hiding this comment.
I don't know. I just left it because it is needed for an "experimental" package that I will never load anyway but I can delete the dependency and the package if you want
There was a problem hiding this comment.
I removed Ghost and the overlay from the baseline. In this case, it would also fix #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3
Fixing baseline by removing deprecated dependencies to Espell and SpecDebugger.
To do that, I also removed all classes that use the deprecated SpecDebugger UI or Espell as an AST evaluator isn't really needed