Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(karpenter): add consolidation setting #1803

Merged
merged 17 commits into from
Jan 20, 2025

Fix nodepool required limits

b82ce70
Select commit
Loading
Failed to load commit list.
Merged

feat(karpenter): add consolidation setting #1803

Fix nodepool required limits
b82ce70
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

53.53% (+0.11%) compared to 359ceb6

View this Pull Request on Codecov

53.53% (+0.11%) compared to 359ceb6

Details

Codecov Report

Attention: Patch coverage is 70.40000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 53.53%. Comparing base (359ceb6) to head (b82ce70).
Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...sources-settings/nodepool-modal/nodepool-modal.tsx 67.16% 9 Missing and 13 partials ⚠️
...esources-settings/nodepools-resources-settings.tsx 76.19% 5 Missing and 5 partials ⚠️
...-resources-settings/cluster-resources-settings.tsx 71.42% 2 Missing and 2 partials ⚠️
...ib/components/inputs/input-toggle/input-toggle.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           staging    #1803      +/-   ##
===========================================
+ Coverage    53.41%   53.53%   +0.11%     
===========================================
  Files         1000     1002       +2     
  Lines        13809    13923     +114     
  Branches      3986     4031      +45     
===========================================
+ Hits          7376     7453      +77     
- Misses        5053     5073      +20     
- Partials      1380     1397      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov