Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(karpenter): add consolidation setting #1803

Open
wants to merge 17 commits into
base: staging
Choose a base branch
from

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Jan 9, 2025

What does this PR do?

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-1409


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview e12a2902-8071-4d9f-aa36-7cbfb6252d14 feat/new-service-list-feedback-FRT-1301
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Write comments that add new information that doesn’t exist in the code

@RemiBonnet RemiBonnet changed the title Feat/karpenter consolidation frt 1409 feat(karpenter): add consolidation setting Jan 9, 2025
Copy link

nx-cloud bot commented Jan 14, 2025

View your CI Pipeline Execution ↗ for commit b82ce70.

Command Status Duration Result
nx affected --target=build --parallel=3 ✅ Succeeded 5m 14s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 4m 30s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 3m 27s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-17 16:12:00 UTC

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 70.40000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 53.53%. Comparing base (359ceb6) to head (b82ce70).
Report is 3 commits behind head on staging.

Files with missing lines Patch % Lines
...sources-settings/nodepool-modal/nodepool-modal.tsx 67.16% 9 Missing and 13 partials ⚠️
...esources-settings/nodepools-resources-settings.tsx 76.19% 5 Missing and 5 partials ⚠️
...-resources-settings/cluster-resources-settings.tsx 71.42% 2 Missing and 2 partials ⚠️
...ib/components/inputs/input-toggle/input-toggle.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1803      +/-   ##
===========================================
+ Coverage    53.41%   53.53%   +0.11%     
===========================================
  Files         1000     1002       +2     
  Lines        13809    13923     +114     
  Branches      3986     4031      +45     
===========================================
+ Hits          7376     7453      +77     
- Misses        5053     5073      +20     
- Partials      1380     1397      +17     
Flag Coverage Δ
unittests 53.53% <70.40%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet marked this pull request as ready for review January 16, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant