Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mc 1404 create prospecting source for publisher air table suggestions #1215

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Mc 1404 create prospecting source for publisher air table suggestions #1215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dad36ec
Prep for new External Editorial prospecting feed
rolf-moz Aug 31, 2024
aa30c50
removed old syndication type
rolf-moz Sep 3, 2024
846ac7a
lint fix
rolf-moz Sep 3, 2024
8ba7a8c
Changed name
rolf-moz Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/api/generatedTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,17 @@ export type CreateRejectedCorpusItemInput = {
url: Scalars['Url'];
};

/**
* Input data for marking the given scheduled surface as reviewed
* by human curators for a given date.
*/
export type CreateScheduleReviewInput = {
/** The date of the schedule that was reviewed, in YYYY-MM-DD format. */
scheduledDate: Scalars['Date'];
/** The GUID of the scheduledSurface that was reviewed. */
scheduledSurfaceGuid: Scalars['ID'];
};

/** Input data for creating a scheduled entry for an Approved Item on a Scheduled Surface. */
export type CreateScheduledCorpusItemInput = {
/**
Expand Down Expand Up @@ -1155,6 +1166,8 @@ export type Mutation = {
createLabel: Label;
/** Creates a Rejected Item. */
createRejectedCorpusItem: RejectedCorpusItem;
/** Marks the given scheduled surface as reviewed by human curators for a given date. */
createScheduleReview: ScheduleReview;
/** Creates a Scheduled Surface Scheduled Item. */
createScheduledCorpusItem: ScheduledCorpusItem;
/** Deletes a CollectionPartnerAssociation. */
Expand Down Expand Up @@ -1282,6 +1295,10 @@ export type MutationCreateRejectedCorpusItemArgs = {
data: CreateRejectedCorpusItemInput;
};

export type MutationCreateScheduleReviewArgs = {
data: CreateScheduleReviewInput;
};

export type MutationCreateScheduledCorpusItemArgs = {
data: CreateScheduledCorpusItemInput;
};
Expand Down Expand Up @@ -1545,6 +1562,7 @@ export enum ProspectType {
CountsModeled = 'COUNTS_MODELED',
Dismissed = 'DISMISSED',
DomainAllowlist = 'DOMAIN_ALLOWLIST',
PublisherSubmitted = 'PUBLISHER_SUBMITTED',
Recommended = 'RECOMMENDED',
RssLogistic = 'RSS_LOGISTIC',
RssLogisticRecent = 'RSS_LOGISTIC_RECENT',
Expand Down Expand Up @@ -1889,6 +1907,19 @@ export type RescheduleScheduledCorpusItemInput = {
source: ScheduledItemSource;
};

/** Contains information about the human curator who reviewed the schedule for a given date and scheduled surface. */
export type ScheduleReview = {
__typename?: 'ScheduleReview';
/** A Unix timestamp of when the scheduled was last reviewed. */
reviewedAt: Scalars['Date'];
/** A single sign-on user identifier of the user who reviewed the schedule. */
reviewedBy: Scalars['String'];
/** The date of the schedule that was reviewed, in YYYY-MM-DD format. */
scheduledDate: Scalars['Date'];
/** The GUID of the scheduledSurface that was reviewed. */
scheduledSurfaceGuid: Scalars['ID'];
};

/**
* A scheduled entry for an Approved Item to appear on a Scheduled Surface.
* For example, a story that is scheduled to appear on December 31st, 2021 on the New Tab in Firefox for the US audience.
Expand Down Expand Up @@ -1935,6 +1966,8 @@ export type ScheduledCorpusItemsResult = {
collectionCount: Scalars['Int'];
/** An array of items for a given Scheduled Surface */
items: Array<ScheduledCorpusItem>;
/** The human review status of the schedule for the given scheduledSurfaceGuid & scheduledDate. */
scheduleReview?: Maybe<ScheduleReview>;
/** The date items are scheduled for, in YYYY-MM-DD format. */
scheduledDate: Scalars['Date'];
/** The number of syndicated articles for the scheduled date. */
Expand Down Expand Up @@ -2104,6 +2137,7 @@ export enum Topics {
Food = 'FOOD',
Gaming = 'GAMING',
HealthFitness = 'HEALTH_FITNESS',
Home = 'HOME',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i unfortunately think we need to manually remove this line. will give context in slack.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually - i'll let @nina-py chime in here to confirm if we have to remove this line or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to keep it in in the generated types as long as we're not using it in frontend code itself - this PR is waiting and has that change: https://github.com/Pocket/curation-admin-tools/pull/1212/files

Parenting = 'PARENTING',
PersonalFinance = 'PERSONAL_FINANCE',
Politics = 'POLITICS',
Expand Down
4 changes: 2 additions & 2 deletions src/curated-corpus/integration-test-mocks/getScheduledSurfacesForUser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@ const allScheduledSurfaces: ScheduledSurface[] = [
ProspectType.TopSaved,
ProspectType.DomainAllowlist,
ProspectType.Dismissed,
ProspectType.SyndicatedRerun,
ProspectType.SyndicatedNew,
ProspectType.CountsModeled,
ProspectType.TimespentModeled,
ProspectType.TitleUrlModeled,
ProspectType.RssLogistic,
ProspectType.RssLogisticRecent,
ProspectType.SlateSchedulerV2,
ProspectType.PublisherSubmitted,
],
},
{
Expand All @@ -37,6 +36,7 @@ const allScheduledSurfaces: ScheduledSurface[] = [
ProspectType.DomainAllowlist,
ProspectType.Dismissed,
ProspectType.TitleUrlModeled,
ProspectType.PublisherSubmitted,
],
},
{
Expand Down