Mc 1404 create prospecting source for publisher air table suggestions #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolf-moz
changed the title
1 task
jpetto
requested changes
Sep 4, 2024
| @@ -2104,6 +2137,7 @@ export enum Topics { | |||
| Food = 'FOOD', | |||
| Gaming = 'GAMING', | |||
| HealthFitness = 'HEALTH_FITNESS', | |||
| Home = 'HOME', | |||
There was a problem hiding this comment.
i unfortunately think we need to manually remove this line. will give context in slack.
There was a problem hiding this comment.
actually - i'll let @nina-py chime in here to confirm if we have to remove this line or not.
There was a problem hiding this comment.
It's ok to keep it in in the generated types as long as we're not using it in frontend code itself - this PR is waiting and has that change: https://github.com/Pocket/curation-admin-tools/pull/1212/files
jpetto
approved these changes
Sep 4, 2024
rolf-moz
deleted the
MC-1404-Create-a-de-de-en-us-Prospecting-source-for-Publisher-AirTable-Suggestions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
What changed? What is the business/product goal?
The Editors would like to have easy access to stories suggested by external publishers.
They are currently being submitted via airtable.
We already have ingestion in our German auto-scheduler, so we are leveraging that to output a new prospect feed in this PR
https://github.com/MozillaSocial/ml-services/pull/430
New type is added in Pocket/content-monorepo#213
References to deprecated Syndication prospect feed are removed as well.
Implementation Decisions
Named the prospect source ExternalEditorial so users know these are external links and thus unvetted.
Only URLs from previously published domains are sent to this feed. We might consider additional security checks in the future.
Deployment steps
References
JIRA ticket:
[
Issue:
Documentation: