Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --container argument from CLIs #394

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions cubids/__init__.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
"""Top-level package for CuBIDS."""

from cubids import (
cli,
config,
constants,
cubids,
metadata_merge,
utils,
validator,
workflows,
)
from cubids import cli, config, constants, cubids, metadata_merge, validator, workflows
from cubids.__about__ import __copyright__, __credits__, __packagename__, __version__

__all__ = [
Expand All @@ -22,7 +13,6 @@
"constants",
"cubids",
"metadata_merge",
"utils",
"validator",
"workflows",
]
51 changes: 0 additions & 51 deletions cubids/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,6 @@ def _parse_validate():
help="Run the BIDS validator sequentially on each subject.",
required=False,
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
default=None,
)
parser.add_argument(
"--ignore-nifti-headers",
action="store_true",
Expand Down Expand Up @@ -251,11 +245,6 @@ def _parse_group():
"then output files will go to the specified location."
),
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)
parser.add_argument(
"--acq-group-level",
default="subject",
Expand Down Expand Up @@ -347,11 +336,6 @@ def _parse_apply():
default=False,
help="ensure that there are no untracked changes before finding groups",
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)
parser.add_argument(
"--acq-group-level",
default="subject",
Expand Down Expand Up @@ -405,11 +389,6 @@ def _parse_datalad_save():
action="store",
help="message for this commit",
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)

return parser

Expand Down Expand Up @@ -442,11 +421,6 @@ def _parse_undo():
"sub-X directories and dataset_description.json"
),
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)

return parser

Expand Down Expand Up @@ -532,11 +506,6 @@ def _parse_copy_exemplars():
# help='only include an exemplar subject from these '
# 'listed Acquisition Groups in the exemplar dataset ',
# required=False)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)
parser.add_argument(
"--force-unlock",
action="store_true",
Expand Down Expand Up @@ -590,11 +559,6 @@ def _parse_add_nifti_info():
default=False,
help="unlock dataset before adding nifti info ",
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)
return parser


Expand Down Expand Up @@ -645,11 +609,6 @@ def _parse_purge():
default=False,
help="ensure that there are no untracked changes before finding groups",
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)
return parser


Expand Down Expand Up @@ -687,11 +646,6 @@ def _parse_remove_metadata_fields():
default=[],
help="space-separated list of metadata fields to remove.",
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)

return parser

Expand Down Expand Up @@ -726,11 +680,6 @@ def _parse_print_metadata_fields():
"sub-X directories and dataset_description.json"
),
)
parser.add_argument(
"--container",
action="store",
help="Docker image tag or Singularity image file.",
)

return parser

Expand Down
4 changes: 3 additions & 1 deletion cubids/config.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
"""Functions for configuring CuBIDS."""

from pathlib import Path
import importlib.resources
from pathlib import Path

import yaml


def load_config(config_file):
"""Load a YAML file containing a configuration for param groups.

Expand Down
2 changes: 0 additions & 2 deletions cubids/tests/test_apply.py
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,6 @@ def test_cubids_apply_intendedfor(
edited_summary_tsv=summary_tsv,
files_tsv=files_tsv,
new_tsv_prefix=None,
container=None,
)

with open(fmap_json) as f:
Expand All @@ -317,5 +316,4 @@ def test_cubids_apply_intendedfor(
edited_summary_tsv=summary_tsv,
files_tsv=files_tsv,
new_tsv_prefix=None,
container=None,
)
6 changes: 3 additions & 3 deletions cubids/tests/test_bond.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
get_data,
)
from cubids.validator import (
bids_validator_version,
build_validator_call,
extract_summary_info,
get_bids_validator_version,
parse_validator_output,
run_validator,
get_bids_validator_version,
extract_summary_info,
update_dataset_description,
bids_validator_version,
)

COMPLETE_KEY_GROUPS = [
Expand Down
2 changes: 1 addition & 1 deletion cubids/tests/utils.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Utility functions for CuBIDS' tests."""

import hashlib
import importlib.resources
import json
import os
import shutil
Expand All @@ -10,7 +11,6 @@
import nibabel as nb
import numpy as np
import pandas as pd
import importlib.resources

TEST_DATA = importlib.resources.files("cubids") / "tests/data"

Expand Down
33 changes: 0 additions & 33 deletions cubids/utils.py

This file was deleted.

Loading
Loading