-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --container
argument from CLIs
#394
base: main
Are you sure you want to change the base?
Conversation
#396 will fix the lingering issue. |
@@ -158,7 +158,6 @@ exclude = [ | |||
"cubids/config.py", | |||
"cubids/data/", | |||
"cubids/tests/", | |||
"cubids/utils/sentry.py", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need sentry anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we use Sentry at all in CuBIDS. Just in our Nipype workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some misalignments of displaying the diff in workflows.py
that makes it incredibly difficult to see what was deleted/added. But as far as I can tell, everything looks to good to me. There're just some conflicts that need to be resolved.
Closes #370.
Changes proposed in this pull request