Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --container argument from CLIs #394

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Remove --container argument from CLIs #394

wants to merge 8 commits into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jan 16, 2025

Closes #370.

Changes proposed in this pull request

  • Remove all use of containers in CuBIDS.

@tsalo
Copy link
Member Author

tsalo commented Jan 16, 2025

#396 will fix the lingering issue.

@tsalo tsalo requested a review from mattcieslak January 16, 2025 19:54
@tsalo tsalo marked this pull request as ready for review January 16, 2025 21:02
@tientong98 tientong98 self-requested a review January 17, 2025 20:14
@@ -158,7 +158,6 @@ exclude = [
"cubids/config.py",
"cubids/data/",
"cubids/tests/",
"cubids/utils/sentry.py",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need sentry anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use Sentry at all in CuBIDS. Just in our Nipype workflows.

Copy link
Contributor

@tientong98 tientong98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some misalignments of displaying the diff in workflows.py that makes it incredibly difficult to see what was deleted/added. But as far as I can tell, everything looks to good to me. There're just some conflicts that need to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all container support
2 participants