Skip to content

Commit

Permalink
Fix Rage Support not enabling Rage damage bonus (#8178)
Browse files Browse the repository at this point in the history
The mod was not applying globally so it wasn't working as a buff

Co-authored-by: LocalIdentity <[email protected]>
  • Loading branch information
LocalIdentity and LocalIdentity authored Aug 14, 2024
1 parent b1108a7 commit 98fcdf1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion src/Data/SkillStatMap.lua
Original file line number Diff line number Diff line change
Expand Up @@ -2060,7 +2060,7 @@ return {
flag("SpellCastTimeAddedToCooldownIfTriggered"),
},
["gain_x_rage_on_attack_hit"] = {
flag("Condition:CanGainRage", nil, ModFlag.Attack, 0, { type = "GlobalEffect", effectType = "Buff" }),
flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" } ),
},
["warcry_count_power_from_enemies"] = {
flag("UsesWarcryPower", { type = "GlobalEffect", effectType = "Buff" })
Expand Down
3 changes: 0 additions & 3 deletions src/Data/Skills/sup_str.lua
Original file line number Diff line number Diff line change
Expand Up @@ -3588,9 +3588,6 @@ skills["SupportRage"] = {
ignoreMinionTypes = true,
statDescriptionScope = "gem_stat_descriptions",
statMap = {
["support_rage_gain_rage_on_melee_hit_cooldown_ms"] = {
flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" } ),
},
["attack_speed_+%_with_at_least_10_rage"] = {
mod("Speed", "INC", nil, ModFlag.Attack, 0, { type = "MultiplierThreshold", var = "Rage", threshold = 10 })
},
Expand Down
3 changes: 0 additions & 3 deletions src/Export/Skills/sup_str.txt
Original file line number Diff line number Diff line change
Expand Up @@ -493,9 +493,6 @@ local skills, mod, flag, skill = ...

#skill SupportRage
statMap = {
["support_rage_gain_rage_on_melee_hit_cooldown_ms"] = {
flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" } ),
},
["attack_speed_+%_with_at_least_10_rage"] = {
mod("Speed", "INC", nil, ModFlag.Attack, 0, { type = "MultiplierThreshold", var = "Rage", threshold = 10 })
},
Expand Down

0 comments on commit 98fcdf1

Please sign in to comment.