Skip to content

Commit

Permalink
Fix crash when allocating Blood Magic with Mana Bond (#8177)
Browse files Browse the repository at this point in the history
Allocating Blood Magic removes the output of `ManaUnreserved` so it crashed the preDamageFunc

Co-authored-by: LocalIdentity <[email protected]>
  • Loading branch information
LocalIdentity and LocalIdentity authored Aug 14, 2024
1 parent 7e52bfa commit b1108a7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Data/Skills/act_int.lua
Original file line number Diff line number Diff line change
Expand Up @@ -12361,7 +12361,7 @@ skills["Manabond"] = {
castTime = 0.8,
preDamageFunc = function(activeSkill, output)
local missingUnreservedManaPercentage = activeSkill.skillData.ManabondMissingUnreservedManaPercentage or 100
local manaGainedAsBaseLightningDamage = math.floor((activeSkill.skillData.ManabondMissingManaGainPercent / 100) * (missingUnreservedManaPercentage / 100) * output.ManaUnreserved)
local manaGainedAsBaseLightningDamage = math.floor((activeSkill.skillData.ManabondMissingManaGainPercent / 100) * (missingUnreservedManaPercentage / 100) * (output.ManaUnreserved or 0))
activeSkill.skillModList:NewMod("LightningMin", "BASE", manaGainedAsBaseLightningDamage, "Manabond gain % missing unreserved mana as base lightning damage")
activeSkill.skillModList:NewMod("LightningMax", "BASE", manaGainedAsBaseLightningDamage, "Manabond gain % missing unreserved mana as base lightning damage")
end,
Expand Down
2 changes: 1 addition & 1 deletion src/Export/Skills/act_int.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2816,7 +2816,7 @@ local skills, mod, flag, skill = ...
#flags spell area arcane
preDamageFunc = function(activeSkill, output)
local missingUnreservedManaPercentage = activeSkill.skillData.ManabondMissingUnreservedManaPercentage or 100
local manaGainedAsBaseLightningDamage = math.floor((activeSkill.skillData.ManabondMissingManaGainPercent / 100) * (missingUnreservedManaPercentage / 100) * output.ManaUnreserved)
local manaGainedAsBaseLightningDamage = math.floor((activeSkill.skillData.ManabondMissingManaGainPercent / 100) * (missingUnreservedManaPercentage / 100) * (output.ManaUnreserved or 0))
activeSkill.skillModList:NewMod("LightningMin", "BASE", manaGainedAsBaseLightningDamage, "Manabond gain % missing unreserved mana as base lightning damage")
activeSkill.skillModList:NewMod("LightningMax", "BASE", manaGainedAsBaseLightningDamage, "Manabond gain % missing unreserved mana as base lightning damage")
end,
Expand Down

0 comments on commit b1108a7

Please sign in to comment.