Removed cupy-tests until they are fixed #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other three triggers are the default
|
Updated the CI-file, so that the gitlab-ci is also triggered, when a new label is added (e.g. the label to start Gitlab-CI) Combined in this PR, as both work on CI in general and gitlab-CI in particular |
|
Actually, I was planning to port some new things to GPU and make use of the cupy tests today. I would rather we skip the single test that runs in parallel and run the other tests for now. |
|
@brownbaerchen we can also do that. I just readded the general tests and commented out the one test, that got stuck. So now it (hopefully) succeeds. |
|
LGTM |
pancetta
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I cannot push to master (which makes sense), this PR removes the cupy-test in gitlab, so that CI now succeeds again. Then failures can be detected easier.
Once, the cupy-tests are fixed, the updated code shall be merged in master and also the tests will be added again.