-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split long project tests into different environments such that they run concurrently #423
Conversation
Hey, this is really cool! Now the tests run much faster! ❤️ |
Love it ! |
Feel free to suggest a better solution regarding the environment files. I just did the easiest thing I could think of, but it's kind of nasty. |
Nice! But also nasty.. I'd appreciate if we could come to a version where each project ships with it's own |
@pancetta Yes, the layout, that you proposed is possible (double checked with pytest-docs ). Then, the tests would go in a sub-dir of each project ( |
Ok, but duplication only refers to the The projects would need to be listed in the CI file, right? |
Yes, correct. The projects would still (all) need to be listed explicitly in the CI-file. So the symlinks would only get rid of the duplication of |
Any volunteers? Otherwise this will have to wait for some long night of mine.. |
I can do it. But this means, that the fixing of cupy (see #424 )will have to wait until this is done. Nevertheless, I would prefer this new order (first this, then the MPI-NCCL issue) as then, the CI runs faster, which leads to better/easier/faster development in general. |
Thoughts, @brownbaerchen ? |
Sounds good to me! |
Well, then, fire at will, @jakob-fritz. The goal is to make the projects as independently as possible, without too much duplication. Good luck! |
I got really tired of waiting so long. I just added environments for the longest running tests. Let me know if you want more or less granular. Also, the environments are the same as the base environment, since only these tests took so long. Tests needing other environments can stay there as far as I am concerned.