Fixes #28022: mecha/AI/hologram bugs from #25078 #28026
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR ParadiseSS13#25078 introduced a few bugs related to AI eyes, mechs, and holograms. This change fixes those bugs. Now, entering a mech with an active hologram eye will first release that eye before granting control of the mech. Double clicking on a turf as an AI while in a mech will no longer unstick the camera from the mech. When exiting a mech, the AI will now properly refocus on its core instead of on the spot that it first entered the mech. AI holograms no longer receive normal audio near their holopads, receiving only holopad-relayed speech now instead. AIs will no longer be able to activate a holopad while occupying a mech.
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
Drsmail
reviewed
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
PR #25078 introduced a few bugs related to AI eyes, mechs, and holograms, which are referenced in #28022. This change fixes those bugs.
Why It's Good For The Game
Bugs are bad. Fixing them is good.
Testing
I booted up a test server and logged in as an AI. I
spawned a phazon mech, and used VV to add an AI tracker to itstrackers.I took control of the mech, and then tried to use a holopad, to no effect. I also tried to double click on a turf, to no effect.
I navigated to another area as the mech.
I then used the eject button to eject from the mech. My camera was refocused on my core, and when I moved away from it, its movement was natural and did not jump to the location that the mech was first entered.
I activated a holopad. I then took control of the mech. The hologram disappeared. I ejected from the mech, and my camera was refocused on the core, and when I moved away from it, its movement was natural, as above.
I logged into the test server with another client as a guest. I joined as a botanist, and jumped to the central primary hallway above the bridge. On the client that I was logged in as an AI, I activated the holopad there. I spoke using departmental radio (
:h) as the AI. The botanist client heard the hologram. (S.O.P.H.I.E. states, "Hello world.") I spoke normally as the botanist. The AI client heard the relayed speech only. (Relayed Speech: Lando Riker says, "Hello world.")Declaration
Changelog
🆑 Ascio
fix: Entering a mech with an active hologram eye will now release that eye before granting control of the mech.
fix: Double clicking on a turf as an AI while in a mech will no longer unstick the camera from the mech.
fix: When exiting a mech, the AI will now properly refocus on its core instead of on the spot that it first entered the mech.
fix: AI will no longer receive duplicate original audio from holopads, and now will receive only relayed speech.
fix: AIs will no longer be able to activate a holopad while occupying a mech.
/:cl: