Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust depot loot a little and remove some irrelevant items. #27398

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

kyunkyunkyun
Copy link
Contributor

@kyunkyunkyun kyunkyunkyun commented Nov 19, 2024

What Does This PR Do

Replaces autosurgeons with standalone implants.

Removes, adds, replaces items from next pools:

  • Armory:
    • Qani-Laaca (40TC) replaces gloves of North Star (40TC).
    • Added proto-adrenal biochip (10TC), toy SR (priceless).
  • Officer:
    • Added toy c20r (25TC), snakesfang (25TC), tactical first aid kit.
    • Removed self-repair module for borgs (I didn't mention it to get the pre-approval), 10 uranium (we have 20 uranium in rare loot).
  • Rare:
    • Chameleon kit (10TC) replaces chameleon jumpsuit.
    • Added chameleon voice change mask (5TC), plate compression module (10TC), hyper medipen (10TC), syndie eva.
    • Removed chameleon stamp, zippo, tactical first aid kit, syndie and black jacket.
  • Common:
    • Added combat and sniper uniforms (from bundles, same as tactical turtlenecks), zippo, chameleon stamp, syndie and black jacket.
    • Removed syndie eva, tactical turtleneck.

Why It's Good For The Game

Up to dating loot with "new" uplink items. Giving few more options for explorers to shine.
I consider Qani-Laaca implant is a good replace for gloves of North Star. You are being able to get benifit from it as an explorer - like completing some ruins or runaway from sentry bot, avoiding his deadly GL shots, meantime gloves give you nothing against simple mobs, they are only useful against other players on station. Qani is good against players as well, but you have a side effect of heart damage and toxins, not just nothing as with gloves.
Proto-adrenal is nowhere as good as other armory loot, but it's something that could just save your life once in a round.
Removing self repair module is good since it requires no syndie techs to build for robo, why would it be in a depot? Also a very common module for a "officer" loot list.

Testing

Compiled, spawned different depot closets, ensured they have new items inside.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
    image

Changelog

🆑
tweak: Syndie Depot received a couple more items to supply their agents among the sector with.
tweak: Syndie Depot's autosurgeons became too expensive for the local regiment, so the implants now should be installed via surgical help.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Nov 20, 2024
@1080pCat 1080pCat added Tweak This PR tweaks something ingame Balance This PR will modify how effective something is or isnt labels Nov 22, 2024
@SteelSlayer SteelSlayer removed the Tweak This PR tweaks something ingame label Nov 22, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 22, 2024
@silverplatedelta
Copy link
Contributor

Balance wise, the only thing here I dislike is the agent ID. Otherwise I think this is a great improvement to the loot pool.

@kyunkyunkyun
Copy link
Contributor Author

Balance wise, the only thing here I dislike is the agent ID.

What's so bad about the agent ID?

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Nov 30, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Dec 1, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team labels Dec 2, 2024
Copy link
Member

@chuga-git chuga-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine. Still awaiting balance team votes.

@silverplatedelta
Copy link
Contributor

Super sorry for not replying to you sooner! This PR slipped through the cracks.

My concern with the agent ID is that it could be used by antagonists (cough clings cough) and do more harm than good. The ability to be untrackable, as well as the customization and access editing is very strong in the hands of those not intended to have it.

@kyunkyunkyun
Copy link
Contributor Author

My concern with the agent ID is that it could be used by antagonists (cough clings cough) and do more harm than good. The ability to be untrackable, as well as the customization and access editing is very strong in the hands of those not intended to have it.

you are right, but cling is already able to get like elite modsuit, stech and all the other goods from the depot for free. If we want to make it harder for them - implement the same system as for agents like not giving access to armory and force blue code on visit. If balance team decides to - agent card might be moved to armory loot or even removed, but honestly this item is superior for civil explorers, way better than anything like a gun or an armor that are useless for them since they are not antags

@Komrad822
Copy link
Contributor

Do not want agent Id in the ruin and do want gloves of the north star to stay as sometimes, explorers will willingly give up their items or be caught by security and thus the gloves have a chance to be used later in the round, whether by antags or the random assistant.

My issue with the agent ID is it is way stronger than people give it credit for. It can be used to steal funds from other people, it can be used to impersonate other people with a masked face, and its ONLY editable by the person imprinted onto it. MEANING, if you gun down the person in space, you cannot edit it at all if they interacted with it earlier. Explorers are walking loot piñatas, dangerous ones, but ones nonetheless. Not really fun when all the loot on them is bound to them imho.

@Code-Lyoko0
Copy link
Contributor

I hold the same view as Silverplate, I think Quani is fine as it does have use for an explorer but the Agent ID is very powerful and I think should not be explorer loot, as stated by Komrad and Silver.

@kyunkyunkyun
Copy link
Contributor Author

Removed controversial agent card.
Keep a Qani implanter which replaces gloves of North Star, as i already said, there is 0 profit for a non-antag explorer getting these gloves, while Qani is able to save you life from range mobs at the cost of your heart health and dealing toxins to you.
As Komrad said, whenever any explorer being caught/gives up his items - Qani stays inside an implanter (which might be used by antags/crew) or being surgically removed from its body and used after. Keep in mind that Qani is Syndicate version, so that is EMP proof and is very valuable compared to the one from RnD.
You are also able to give it to the scientists, it gives you 4 syndie tech, same as esword. Gloves give you nothing.

@silverplatedelta
Copy link
Contributor

Thank you for adressing this, I will remove my holding objection shortly

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 12, 2025
@Burzah Burzah added this pull request to the merge queue Jan 13, 2025
Merged via the queue into ParadiseSS13:master with commit 5337cc1 Jan 13, 2025
17 checks passed
warriorstar-orion added a commit to warriorstar-orion/Paradise that referenced this pull request Jan 15, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
* Scatter depot loot to the solar winds.

* make zoo spawners guaranteed

* INFINITY also used for spawn_all_loot, whoops

* move abandoned sec shuttle spawner to locked crate

* Can't use spawn_all_loot and nested lists together

* Reduce pixel offset on mech transport spawn scatter

* set updatepaths script number

* incorporate changes from #27398 and remove old spawners

* some numbers tweaking

* pct -> %

* move briefcase from common to rare for ruins

* lower loot budget from 1800 -> 1700
@kyunkyunkyun kyunkyunkyun deleted the depot-loot branch January 24, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Balance This PR will modify how effective something is or isnt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants