Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change concept.concept_id from int to str. #91

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Change concept.concept_id from int to str. #91

merged 1 commit into from
Jan 3, 2023

Conversation

Wim-De-Clercq
Copy link
Contributor

Issue #87

@Wim-De-Clercq Wim-De-Clercq force-pushed the feature/87_concept_id_string branch 3 times, most recently from cbded38 to 80b8e4b Compare January 2, 2023 14:40
koenedaele
koenedaele approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@koenedaele koenedaele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor comment, but that's just something I'm curious about.

@Wim-De-Clercq Wim-De-Clercq force-pushed the feature/87_concept_id_string branch from 80b8e4b to fe17583 Compare January 3, 2023 08:12
@koenedaele koenedaele merged commit 08a7549 into OnroerendErfgoed:develop Jan 3, 2023
koenedaele added a commit that referenced this pull request Jan 3, 2023
@koenedaele
Merge branch 'develop' of github.com:OnroerendErfgoed/skosprovider_sq…
26754e8 
…lalchemy into develop

* 'develop' of github.com:OnroerendErfgoed/skosprovider_sqlalchemy:
  Change concept.concept_id from int to str. (#91)
koenedaele added a commit that referenced this pull request Jan 19, 2023
@koenedaele
Merge version 2.0.0 for release
d363065 
* develop: (24 commits)
  Fix typo
  Prepare for release
  Update docs with upgrade info.
  Test Python 3.11 compatibility.
  Update changelog with constructor update.
  Feature/95 provider super (#96)
  Remove nose.collector
  Stop building universal wheels.
  Update HISTORY
  Upgrade requirements + sqlachemy 2.0 prep (#94)
  Update HISTORY
  Change concept.concept_id from int to str. (#91)
  Update HISTORY.
  Drop pyup config file. (#92)
  Project housekeeping.
  Add HISTORY entry for 1.0.0. Fixes #89
  Update setup.py
  Drop python 3.6 and 3.7. Add python 3.9 and 3.10. (#93)
  Remove Scrutinizer.
  Add Scrutinizer config.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koenedaele koenedaele koenedaele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wim-De-Clercq @koenedaele