Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneSignal-Subscription-Id to all Update User requests #1353

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Jan 3, 2024

Description

One Line Summary

Add the OneSignal-Subscription-Id header to all Update User requests, not just the ones with deltas.

Details

Motivation

  • Previously, we added the OneSignal-Subscription-Id header to update user requests that had deltas in the body.
  • Now, we will add this header to all update user requests. This endpoint may have expected this all along, but this was a recent ask of the SDK.

Scope

A header in Update User requests for backend to process.

Testing

Unit testing

None

Manual testing

Building and running on iPhone 13 with iOS 17.1.2.

  1. Change SDK version and Sent a bunch of tags
  2. Check honeycomb to see a bunch of requests with the header and that SDK version

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

- Previously, we added the `OneSignal-Subscription-Id` header to update user requests that had `deltas` in the body.
- Now, we will add this header to all update user requests. This endpoint may have expected this all along, but this was a recent ask of the SDK.
@nan-li nan-li force-pushed the add_to_all_OneSignal-Subscription-Id branch from ca5a478 to 9a30969 Compare January 3, 2024 23:19
@nan-li nan-li merged commit eae5234 into main Jan 5, 2024
4 checks passed
@nan-li nan-li deleted the add_to_all_OneSignal-Subscription-Id branch January 5, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants