Skip to content

Commit

Permalink
Add OneSignal-Subscription-Id to all Update User requests
Browse files Browse the repository at this point in the history
- Previously, we added the `OneSignal-Subscription-Id` header to update user requests that had `deltas` in the body.
- Now, we will add this header to all update user requests. This endpoint may have expected this all along, but this was a recent ask of the SDK.
  • Loading branch information
nan-li committed Jan 3, 2024
1 parent 4b92542 commit 9a30969
Showing 1 changed file with 8 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class OSRequestUpdateProperties: OneSignalRequest, OSUserRequest {
func prepareForExecution() -> Bool {
if let onesignalId = identityModel.onesignalId,
let appId = OneSignalConfigManager.getAppId(),
addPushSubscriptionIdToAdditionalHeadersIfNeeded() {
addPushSubscriptionIdToAdditionalHeaders() {
self.addJWTHeader(identityModel: identityModel)
self.path = "apps/\(appId)/users/by/\(OS_ONESIGNAL_ID)/\(onesignalId)"
return true
Expand All @@ -55,21 +55,15 @@ class OSRequestUpdateProperties: OneSignalRequest, OSUserRequest {
}
}

func addPushSubscriptionIdToAdditionalHeadersIfNeeded() -> Bool {
guard let parameters = self.parameters else {
func addPushSubscriptionIdToAdditionalHeaders() -> Bool {
if let pushSubscriptionId = OneSignalUserManagerImpl.sharedInstance.pushSubscriptionId {
var additionalHeaders = self.additionalHeaders ?? [String: String]()
additionalHeaders["OneSignal-Subscription-Id"] = pushSubscriptionId
self.additionalHeaders = additionalHeaders
return true
} else {
return false
}
if parameters["deltas"] != nil { // , !parameters["deltas"].isEmpty
if let pushSubscriptionId = OneSignalUserManagerImpl.sharedInstance.pushSubscriptionId {
var additionalHeaders = self.additionalHeaders ?? [String: String]()
additionalHeaders["OneSignal-Subscription-Id"] = pushSubscriptionId
self.additionalHeaders = additionalHeaders
return true
} else {
return false
}
}
return true
}

init(properties: [String: Any], deltas: [String: Any]?, refreshDeviceMetadata: Bool?, modelToUpdate: OSPropertiesModel, identityModel: OSIdentityModel) {
Expand Down

0 comments on commit 9a30969

Please sign in to comment.