-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] OneSignalConfig.androidlib version numbers in build.gradle #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not specifying a version number sets it to a low version instead. minSDKVersion was set to 1 and added the READ_PHONE_STATE permission. Lower build-tools versions than the one the Unity Editor comes with were being required when building for Android. compileSDKVersion is required to be defined inorder to build and has been changed to match the version specified in Unity
Deleted OneSignalConfig.androidlib from example project and ran Window > OneSignal SDK Setup > Copy Android plugin to Assets
jkasten2
approved these changes
Dec 12, 2023
com.onesignal.unity.android/Editor/OneSignalConfig.androidlib/build.gradle
Show resolved
Hide resolved
OneSignalExample/Assets/Plugins/Android/OneSignalConfig.androidlib/build.gradle
Show resolved
Hide resolved
jinliu9508
pushed a commit
that referenced
this pull request
Jan 2, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508
pushed a commit
that referenced
this pull request
Feb 23, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508
pushed a commit
that referenced
this pull request
Mar 1, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Sets version numbers in the OneSignalConfig.androidlib build.gradle to match the versions specified in Unity
Details
Motivation
Fixes #670 READ_PHONE_STATE permission being added to Android builds
Fixes lower build-tools versions being needed for Android builds than the version the Unity Editor comes with
Not specifying a version number in the build.gradle sets it to a low version instead. minSDKVersion was set to 1 and added the READ_PHONE_STATE permission. Lower build-tools versions than the one the Unity Editor comes with were being required when building for Android. compileSDKVersion and targetSDKVersion have also been changed to match the versions specified in Unity
Scope
OneSignalConfig.androidlib has changed and devs need to regenerate it to apply the changes.
To apply the fix devs need to:
Testing
Manual testing
Tested OneSignal initialization, app build with Unity 2021.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is