Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] OneSignalConfig.androidlib version numbers in build.gradle #673

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Dec 12, 2023

Description

One Line Summary

Sets version numbers in the OneSignalConfig.androidlib build.gradle to match the versions specified in Unity

Details

Motivation

Fixes #670 READ_PHONE_STATE permission being added to Android builds
Fixes lower build-tools versions being needed for Android builds than the version the Unity Editor comes with

  • I was able to reproduce a licensing 30.0.3 build-tools build error in a new project with the OneSignal SDK on Unity 2022.3.14 which comes with build-tools 32.0.0. The lower build-tools error version may differ depending on the Unity Editor version.

Not specifying a version number in the build.gradle sets it to a low version instead. minSDKVersion was set to 1 and added the READ_PHONE_STATE permission. Lower build-tools versions than the one the Unity Editor comes with were being required when building for Android. compileSDKVersion and targetSDKVersion have also been changed to match the versions specified in Unity

Scope

OneSignalConfig.androidlib has changed and devs need to regenerate it to apply the changes.
To apply the fix devs need to:

  1. Delete their OneSignalConfig.androidlib
  2. Go to Window > OneSignal SDK Setup and run the "Copy Android plugin to Assets" step

Testing

Manual testing

Tested OneSignal initialization, app build with Unity 2021.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Not specifying a version number sets it to a low version instead. minSDKVersion was set to 1 and added the READ_PHONE_STATE permission. Lower build-tools versions than the one the Unity Editor comes with were being required when building for Android. compileSDKVersion is required to be defined inorder to build and has been changed to match the version specified in Unity
Deleted OneSignalConfig.androidlib from example project and ran Window > OneSignal SDK Setup > Copy Android plugin to Assets
@shepherd-l shepherd-l merged commit 1aec0b4 into user-model/main Dec 12, 2023
1 check passed
@shepherd-l shepherd-l deleted the fix/androidlibBuildGradle branch December 12, 2023 20:30
jinliu9508 pushed a commit that referenced this pull request Jan 2, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508 pushed a commit that referenced this pull request Feb 23, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508 pushed a commit that referenced this pull request Mar 1, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
[Fix] OneSignalConfig.androidlib version numbers in build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants