Merge pull request #673 from OneSignal/fix/androidlibBuildGradle

[Fix] OneSignalConfig.androidlib version numbers in build.gradle
OneSignal · Jan 2, 2024 · 4285c63 · 4285c63
2 parents 8c42771 + ce4f325
commit 4285c63
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/OneSignalExample/Assets/OneSignal/CHANGELOG.md b/OneSignalExample/Assets/OneSignal/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 ### Fixed
 - Duplicate symbol errors when building with other iOS plugins
+- Removed READ_PHONE_STATE permission in Android builds. Delete your OneSignalConfig.androidlib and run the 
+"Copy Android plugin to Assets" step in **Window > OneSignal SDK Setup** to apply the fix.
+- Fixed lower build-tools versions being needed for Android builds. Delete your OneSignalConfig.androidlib and run the 
+"Copy Android plugin to Assets" step in **Window > OneSignal SDK Setup** to apply the fix.
 ### Changed
 - Updated included Android SDK to [5.0.4](https://github.com/OneSignal/OneSignal-Android-SDK/releases/tag/5.0.4)
 - Updated included iOS SDK to [5.0.4](https://github.com/OneSignal/OneSignal-iOS-SDK/releases/tag/5.0.4)

diff --git a/OneSignalExample/Assets/Plugins/Android/OneSignalConfig.androidlib/build.gradle b/OneSignalExample/Assets/Plugins/Android/OneSignalConfig.androidlib/build.gradle
@@ -7,11 +7,16 @@ android {
         }
     }
 
+    def unityLib = project(':unityLibrary').extensions.getByName('android')
+
    defaultConfig {
-       consumerProguardFiles "consumer-proguard.pro"
+        consumerProguardFiles "consumer-proguard.pro"
+        minSdkVersion unityLib.defaultConfig.minSdk
+        targetSdkVersion unityLib.defaultConfig.targetSdk
    }
 
-    compileSdkVersion 31
+    compileSdkVersion unityLib.compileSdkVersion
+    buildToolsVersion unityLib.buildToolsVersion
 
     lintOptions {
         abortOnError false

diff --git a/com.onesignal.unity.android/Editor/OneSignalConfig.androidlib/build.gradle b/com.onesignal.unity.android/Editor/OneSignalConfig.androidlib/build.gradle
@@ -7,11 +7,16 @@ android {
         }
     }
 
+    def unityLib = project(':unityLibrary').extensions.getByName('android')
+
    defaultConfig {
-       consumerProguardFiles "consumer-proguard.pro"
+        consumerProguardFiles "consumer-proguard.pro"
+        minSdkVersion unityLib.defaultConfig.minSdk
+        targetSdkVersion unityLib.defaultConfig.targetSdk
    }
 
-    compileSdkVersion 31
+    compileSdkVersion unityLib.compileSdkVersion
+    buildToolsVersion unityLib.buildToolsVersion
 
     lintOptions {
         abortOnError false