Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] stock_release_channel: refactor compute count #699

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[14.0][IMP] stock_release_channel: refactor compute count #699

merged 1 commit into from
Nov 9, 2023

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Jul 31, 2023 •
edited
Loading

This PR makes it easier to extend the stock_release_channel module
it allows to easily extend the fields which should be computed

@mt-software-de mt-software-de force-pushed the 14.0-stock_release_channel-refactor-compute_count branch from ba6bd4d to 0c079d6 Compare July 31, 2023 21:26
@mt-software-de
Copy link
Contributor Author

cc @jbaudoux

@mt-software-de mt-software-de marked this pull request as ready for review July 31, 2023 21:33
@mt-software-de mt-software-de force-pushed the 14.0-stock_release_channel-refactor-compute_count branch from 0c079d6 to ef10934 Compare July 31, 2023 21:34
@jbaudoux
Copy link
Contributor

jbaudoux commented Aug 1, 2023

cc @sebalix @simahawk @lmignon

@mt-software-de mt-software-de force-pushed the 14.0-stock_release_channel-refactor-compute_count branch from ef10934 to 05cf0f2 Compare August 4, 2023 10:28
@mt-software-de mt-software-de force-pushed the 14.0-stock_release_channel-refactor-compute_count branch from 05cf0f2 to aed1f87 Compare November 6, 2023 15:31
@mt-software-de
Copy link
Contributor Author

ping @sebalix @simahawk @lmignon

@mt-software-de mt-software-de force-pushed the 14.0-stock_release_channel-refactor-compute_count branch from aed1f87 to 4fc061b Compare November 7, 2023 16:58
simahawk
simahawk approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jbaudoux
Copy link
Contributor

jbaudoux commented Nov 9, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-699-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cccfc21 into OCA:14.0 Nov 9, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 16a9419. Thanks a lot for contributing to OCA. ❤️

@mt-software-de mt-software-de mentioned this pull request Mar 6, 2024
Merged
@jbaudoux jbaudoux mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mt-software-de @jbaudoux @OCA-git-bot @simahawk @lmignon