Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] stock_release_channel_show_volume/weight #844

Merged
merged 8 commits into from
Mar 19, 2024
Merged

[16.0][ADD] stock_release_channel_show_volume/weight #844

merged 8 commits into from
Mar 19, 2024

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Feb 23, 2024 •
edited
Loading

  • stock_release_channel: Dashboard beautification + allow to show/hide last done delivery
    • Clean display using Flex box
    • Transfers button moved on progress bar
    • Use kanban progress instead of form progressbar widget
    • Plan shipment button moved to 3-dots actions
    • Added margin on action labels
    • Display of "Last picking done transfer" is now configurable
  • stock_release_channel_show_volume: Show volumes on release channels
  • stock_release_channel_show_weight: Show weight on release channels

Before

image

After

image image

cc @mt-software-de @sebalix

@jbaudoux jbaudoux force-pushed the 16-stock_release_channel_show_volume branch 2 times, most recently from f7f194e to d29e9e3 Compare February 25, 2024 09:23
@jbaudoux jbaudoux changed the title [16.0][ADD] stock_release_channel_show_volume [16.0][ADD] stock_release_channel_show_volume/weight Feb 25, 2024
@jbaudoux jbaudoux force-pushed the 16-stock_release_channel_show_volume branch 7 times, most recently from 2ed8f0a to d725ff7 Compare February 26, 2024 09:09
@jbaudoux jbaudoux marked this pull request as ready for review February 26, 2024 09:10
@jbaudoux
Copy link
Contributor Author

The counters in the below section should be adapted (not part of this PR):

  • Waiting: Count only first picking of the chain in waiting availability, so what is waiting a replenishment.
  • Late: Count only first picking (so take ready or waiting), so either pick is late, or pack is late if pick is done. In a pick/pack/ship, we don't want to count 3 times late for a single SO.
  • Priority: Count only first (so take ready or waiting) picking, so either pick is late, or pack is late if pick is done. In a pick/pack/ship, we don't want to count 3 times late for a single SO.

@sebalix
Copy link
Contributor

sebalix commented Feb 27, 2024

Build fixed here: #849

@jbaudoux
Copy link
Contributor Author

Other build fix here: #850

@jbaudoux
Copy link
Contributor Author

Other build fix here #851

@jbaudoux jbaudoux force-pushed the 16-stock_release_channel_show_volume branch from d725ff7 to 803fa12 Compare March 4, 2024 15:34
@jbaudoux
Copy link
Contributor Author

jbaudoux commented Mar 4, 2024

rebased

@jbaudoux jbaudoux force-pushed the 16-stock_release_channel_show_volume branch from 803fa12 to cb8e931 Compare March 5, 2024 11:30
sebalix
sebalix approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit 47e8646 can be squashed in [ADD] stock_release_channel_show_volume

mt-software-de
mt-software-de approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, could you please add my Copyright

stock_release_channel/models/stock_release_channel.py Outdated
@@ -1,7 +1,10 @@
# Copyright 2020 Camptocamp
# Copyright 2024 Jacques-Etienne Baudoux (BCIM) <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add my copyright, i forgot to add it. in #699

Suggested change
# Copyright 2024 Jacques-Etienne Baudoux (BCIM) <[email protected]>
# Copyright 2023 Michael Tietz (MT Software) <[email protected]>
# Copyright 2024 Jacques-Etienne Baudoux (BCIM) <[email protected]>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jbaudoux jbaudoux force-pushed the 16-stock_release_channel_show_volume branch from cb8e931 to 63725d2 Compare March 19, 2024 14:11
@jbaudoux
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-844-by-jbaudoux-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8a63c92 into OCA:16.0 Mar 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ee3000a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mt-software-de mt-software-de mt-software-de approved these changes

@sebalix sebalix sebalix approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbaudoux @sebalix @OCA-git-bot @mt-software-de