Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] purchase_duplicate_check: Module added #2516
base: 16.0
Are you sure you want to change the base?
[16.0][ADD] purchase_duplicate_check: Module added #2516
Changes from 2 commits
cff5054
ffcc004
1dda2e5
41e2a9d
8477e98
cb3b7af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, create separate method to check settings, e.g.:
and
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, create separate file for this model:
purchase_order_line.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is necessary to use the
read_group
method instead of searching for records in a loop, which will reduce the load and optimize the query into the database.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message_parts = []
Check warning on line 93 in purchase_duplicate_check/models/purchase_order.py
Codecov / codecov/patch
purchase_duplicate_check/models/purchase_order.py#L93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message_parts.append(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"".join(message_parts)
Check warning on line 106 in purchase_duplicate_check/models/purchase_order.py
Codecov / codecov/patch
purchase_duplicate_check/models/purchase_order.py#L105-L106
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, rename
create_activity_repeating_orders
->allow_create_activity_repeating_orders
Check warning on line 19 in purchase_duplicate_check/models/res_config_settings.py
Codecov / codecov/patch
purchase_duplicate_check/models/res_config_settings.py#L19