[16.0][ADD] purchase_duplicate_check: Module added

[geomer198]

This module adds the following features to the Purchase App:

If there are pending RFQs or Purchase orders with associated incoming stock picking not in the "Done" state for the Product in the PO Line:

• Add Confirmation Wizard if there's an existing RFQ/undelivered PO for the same products on the RFQ confirmation
• Add the "Pending orders" field to the PO Line
• Assign Acitivty for the responsible user to check the associated orders

[GabbasovDinar]

Suggested change

	def _prepare_pending_orders_message(self, product_id):
	"""
	Prepare pending order line message
	:param product_id: product.product record id
	:return str: message
	"""
	message = ""
	for order in self:
	product_line = order.order_line.filtered(
	lambda line: line.product_id.id == product_id
	)
	if not product_line:
	continue
	product_qty = sum(product_line.mapped("product_qty"))
	order_date = order.create_date.date()
	order_href = (
	f"<a href='/web#id={order.id}&model={order._name}'>{order.name}</a>"
	)
	type_ = order.state in ["draft", "sent"] and "RFQ" or "PO"
	message += (
	f"{type_}: {order_href} date: {order_date} Qty: {product_qty}<br/>"
	)
	return message
	def _prepare_pending_orders_message(self, product_id):
	"""
	Prepare pending order line message
	:param product_id: product.product record id
	:return str: message
	"""
	self.ensure_one()
	order_lines = self.env["purchase.order.line"].search([
	('product_id', '=', product_id),
	('order_id', 'in', self.ids)
	])
	message_parts = []
	for line in order_lines:
	order = line.order_id
	order_href = f"<a href='/web#id={order.id}&model={order._name}'>{order.name}</a>"
	type_ = "RFQ" if order.state in ["draft", "sent"] else "PO"
	message_parts.append(
	f"{type_}: {order_href} date: {order.create_date.date()} Qty: {line.product_qty}<br/>"
	)
	return "".join(message_parts)

[GabbasovDinar]

please, create separate method to check settings, e.g.:

def _is_activity_enabled(self):
    """
    Check if activity for repeating orders is enabled.
    :return: bool
    """
    return self.env["ir.config_parameter"].sudo().get_param(
        "purchase_duplicate_check.create_activity_repeating_orders", False
    )

and

def _check_pending_order(self):
    """
    Check for pending orders and trigger confirmation wizard if needed.
    """
    if self._is_activity_enabled() and not self._context.get("skip_rfq_confirmation"):
        return self.env["confirmation.wizard"].with_context(
            skip_rfq_confirmation=True
        ).confirm_pending_order(self)

[GabbasovDinar]

def button_confirm(self):
    """
    Confirm the purchase order.
    :return: action or super
    """
    action = self._check_pending_order()
    return action or super().button_confirm()

[GabbasovDinar]

please, create separate file for this model: purchase_order_line.py

[GabbasovDinar]

message_parts = []

[GabbasovDinar]

message_parts.append(

[GabbasovDinar]

"".join(message_parts)

[GabbasovDinar]

it is necessary to use the read_group method instead of searching for records in a loop, which will reduce the load and optimize the query into the database.

[GabbasovDinar]

please, rename create_activity_repeating_orders -> allow_create_activity_repeating_orders

[GabbasovDinar]

Suggested change

	for record in records:
	self.env["mail.activity"].create(
	{
	"user_id": activity_type.default_user_id.id or self.env.user.id,
	"activity_type_id": activity_type.id,
	"res_id": record.id,
	"res_model_id": model_id,
	"note": self.message,
	}
	)
	message = self.message
	user_id = activity_type.default_user_id.id or self.env.user.id
	activity_type_id = activity_type.id
	activity_vals_list = []
	for record in records:
	activity_vals_list.append({
	"user_id": user_id,
	"activity_type_id": activity_type_id,
	"res_id": record.id,
	"res_model_id": model_id,
	"note":message,
	})
	if activity_vals_list:
	self.env["mail.activity"].create(activity_vals_list)

[hoangtrann]

is repeating orders here mean duplicated orders?

[geomer198]

is repeating orders here mean duplicated orders?

Yes

[hoangtrann]

I think let's use duplicated instead of repeating then

[hoangtrann]

I think you do need at least @api.depends('product_id') here

[hoangtrann]

@geomer198 any comment?

[geomer198]

@geomer198 any comment?

This compute method have many dependencies, that is why I don't write depends decorator here.

[hoangtrann]

This will looks like RFQ: PO001 date: 01/01/2025 Qty: 10.0, it would be much better to be shown as RFQ: PO001 orders 10.0 unit, to confirm by 01/01/2025 and PO: PO001 orders 10.0 unit, expected to received by 01/01/2025

[geomer198]

This will looks like RFQ: PO001 date: 01/01/2025 Qty: 10.0, it would be much better to be shown as RFQ: PO001 orders 10.0 unit, to confirm by 01/01/2025 and PO: PO001 orders 10.0 unit, expected to received by 01/01/2025

I think this is too much.

[hoangtrann]

then at least separate the components with - or ;

[hoangtrann]

test is also failing, please check

[hoangtrann]

Code LGTM