Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when exporting scalar text #652

Merged
merged 17 commits into from
Feb 11, 2025
Merged

Fix bug when exporting scalar text #652

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7f146b0
Add unittest for this bug
ehennestad Jan 30, 2025
7442a10
Update mapData2H5.m
ehennestad Jan 30, 2025
d97c83e
Update read_indexed_column.m
ehennestad Jan 30, 2025
863d319
Fix broken test
ehennestad Jan 30, 2025
63c2194
add test-requirement
ehennestad Jan 30, 2025
eff1af0
Merge branch 'ehennestad-patch-fix-typo' into 650-bug-exporting-scala…
ehennestad Jan 30, 2025
98a2d44
Merge branch 'master' into 650-bug-exporting-scalar-text
ehennestad Jan 30, 2025
39c943c
Merge branch 'master' into 650-bug-exporting-scalar-text
bendichter Feb 3, 2025
14d2f3d
Merge branch 'master' into 650-bug-exporting-scalar-text
ehennestad Feb 3, 2025
07a720a
Merge branch 'main' into 650-bug-exporting-scalar-text
ehennestad Feb 3, 2025
ee4451c
Update unittest
ehennestad Feb 4, 2025
e40e344
Merge branch 'main' into 650-bug-exporting-scalar-text
ehennestad Feb 4, 2025
3eceda3
Merge branch 'main' into 650-bug-exporting-scalar-text
ehennestad Feb 5, 2025
6bb03c8
Merge branch 'main' into 650-bug-exporting-scalar-text
ehennestad Feb 10, 2025
e10194a
Remove test
ehennestad Feb 11, 2025
5ec8644
Remove utility method
ehennestad Feb 11, 2025
1808018
Merge branch 'main' into 650-bug-exporting-scalar-text
ehennestad Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion +io/mapData2H5.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
unlimited_size = H5ML.get_constant_value('H5S_UNLIMITED');
%determine space size
if ischar(data)
if ~forceArray && size(data,1) == 1
if ~forceArray && (size(data,1) == 1 || isempty(data))
sid = H5S.create('H5S_SCALAR');
else
dims = size(data, 1);
Expand Down