-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug when exporting scalar text #652
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 137 137
Lines 5277 5277
=======================================
Hits 5034 5034
Misses 243 243 ☔ View full report in Codecov by Sentry. |
I'm not really a big fan of supporting empty strings at all. It seems the only time you would ever use an empty string would be to get around providing a required attribute, right? |
I guess, but now those should be required (if a required property is empty, it would throw an error on export), so this PR might be obsolete. Also, the default value for a string property (in MATLAB) is an empty string, but on the other hand I don't think empty values are exported. In any case, this still fixes a bug in my opinion |
Motivation
Fix bug discovered in issue #650
How to test the behavior?
Todo
Checklist
fix #XX
whereXX
is the issue number?