Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up the utils package #1198

Open
joshklop opened this issue Sep 5, 2023 · 3 comments
Open

Split up the utils package #1198

joshklop opened this issue Sep 5, 2023 · 3 comments

Comments

@joshklop
Copy link
Contributor

joshklop commented Sep 5, 2023

For example, we can have small network and log packages.

Two benefits:

  • Clarity. Better to avoid ambiguous package names like common, utils, pkg, etc.
  • Dependency management. A user may depend on a package that only uses utils/log and utils/network, but that user will have the full utils package compiled into the binary.
@joshklop
Copy link
Contributor Author

joshklop commented Sep 5, 2023

Note: would like to avoid implementing this until @IronGauntlets (and anyone else who has an opinion) has a say.

@rianhughes
Copy link
Contributor

rianhughes commented Sep 6, 2023

I would also be in favour of this, and think it's also relevant for the final point in the refactoring PR
"Extract common types from the feeder package and rpc package to the utils package to reduce duplication."

@IronGauntlets
Copy link
Contributor

@joshklop I am happy to split the utils package into multiple sub-packages. It might be better to have them as a separate package at the root level. I don't have a strong opinion on either one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants