Set default data directory correctly #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshklop
force-pushed
the
joshklop/datadir
branch
from
1d5c90a to
4944f80
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
==========================================
+ Coverage 74.10% 74.15% +0.04%
==========================================
Files 73 72 -1
Lines 7897 7873 -24
==========================================
- Hits 5852 5838 -14
+ Misses 1578 1572 -6
+ Partials 467 463 -4
☔ View full report in Codecov by Sentry. |
joshklop
requested review from
a team,
IronGauntlets and
omerfirmak
and removed request for
a team
omerfirmak
reviewed
Sep 20, 2023
joshklop
force-pushed
the
joshklop/datadir
branch
3 times, most recently
from
4cb4204 to
3a29c64
Compare
We now use cwd/juno as the data directory. Previously, we set the default to the empty string "" and manually set the default directory in `node.New`. This meant the incorrect default was printed in two cases: 1. `--help` 2. When printing the config on boot. Finally, this centralizes all of our config management to the `cmd/juno` package; if `juno.NewCmd.Execute` returns without an error, the config is structurally valid.
joshklop
force-pushed
the
joshklop/datadir
branch
from
3a29c64 to
040e83c
Compare
IronGauntlets
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1198