Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slog based logging #1209

Closed
wants to merge 6 commits into from
Closed

Slog based logging #1209

wants to merge 6 commits into from

Conversation

Exca-DK
Copy link
Contributor

@Exca-DK Exca-DK commented Sep 8, 2023

closes #1164, part of #1198

The target is 1:1 of old formatting. Not possible with standard slog handlers

@joshklop
Copy link
Contributor

Thank you for your effort there @Exca-DK. I don't think it's necessary to match the old format.

If we could get away with using slog defaults and remove everything but the interface (and possibly no-op implementation) from utils/log.go, that would be amazing.

@Exca-DK
Copy link
Contributor Author

Exca-DK commented Sep 20, 2023

If we want to go with defaults then we will also need to remove the colors flag since slog doesn't support it.

@joshklop
Copy link
Contributor

If we want to go with defaults then we will also need to remove the colors flag since slog doesn't support it.

Thanks for pointing that out. It appears zap is implementing its own slog handlers. Shall we continue using zap's nice features and let it handle the slog migration? cc @IronGauntlets

@IronGauntlets
Copy link
Contributor

Thanks for pointing that out. It appears zap is implementing its own slog handlers. Shall we continue using zap's nice features and let it handle the slog migration? cc @IronGauntlets

Sounds good. We can close the #1164.

@Exca-DK
Copy link
Contributor Author

Exca-DK commented Sep 26, 2023

Closing since the issue is closed too.

@Exca-DK Exca-DK closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use golang's slog package
3 participants