Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit closes #538 by adding a pre-commit hook that lints files staged for commits. This keeps the same eslinting rules as #555, but automates them in the developer process.
During the pre-commit hook,
eslint --fix
is run, which will automatically take care of formatting lint rules as per our config. I tried integrating prettier which does code formatting nicely, however ran into an issue whereeslint --fix
wouldn't automatically fix. I think it may be related to this issue: prettier/prettier-vscode#870, or have something to do with the complexity of usingairbnb-base
,ember
, andprettier
to work together.Here's an example of how lint-staged and husky work in the git commit process, fixing some formatting:
And here's what this would do if you were trying to commit code with a lint error (which would also fail our ember tests):