Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier code formatter and automate as pre-commit hook #565

Closed
wants to merge 1 commit into from

Conversation

bfreeds
Copy link

@bfreeds bfreeds commented Jan 14, 2020

@bfreeds bfreeds force-pushed the 538-automate-linting branch from 5862235 to 6448996 Compare January 14, 2020 20:28
This commit adds prettier using the recommended configuration for
integrating with eslint:
https://prettier.io/docs/en/integrating-with-linters.html

I also added a .prettierrc.js file to configure our formatting based
on the existing .editorconfig.
https://prettier.io/docs/en/configuration.html
@bfreeds bfreeds force-pushed the 538-automate-linting branch from 6448996 to 8752435 Compare January 14, 2020 20:30
Comment on lines +6 to +7
endOfLine: 'lf'
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironiccc! :)

@bfreeds
Copy link
Author

bfreeds commented Jan 14, 2020

Ran into some issues with configuring prettier, just added the pre-commit hook instead (closing this in favor of #570 instead).

@bfreeds bfreeds closed this Jan 14, 2020
@bfreeds bfreeds deleted the 538-automate-linting branch January 14, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants