Fix issues from RPV2 Tutorial #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
Signed-off-by: Ryan Wolf <[email protected]>
This was referenced Aug 27, 2024
Closed
Signed-off-by: Ryan Wolf <[email protected]>
yyu22
pushed a commit
to yyu22/NeMo-Curator
that referenced
this pull request
Oct 9, 2024
* Add worker adjustment based on memory for add_id Signed-off-by: Ryan Wolf <[email protected]> * Fix map buckets text field Signed-off-by: Ryan Wolf <[email protected]> * Fix mismatch metadata in add_id Signed-off-by: Ryan Wolf <[email protected]> * Address Ayush's review Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]> Signed-off-by: Yang Yu <[email protected]>
yyu22
pushed a commit
to yyu22/NeMo-Curator
that referenced
this pull request
Oct 10, 2024
* Add worker adjustment based on memory for add_id Signed-off-by: Ryan Wolf <[email protected]> * Fix map buckets text field Signed-off-by: Ryan Wolf <[email protected]> * Fix mismatch metadata in add_id Signed-off-by: Ryan Wolf <[email protected]> * Address Ayush's review Signed-off-by: Ryan Wolf <[email protected]> --------- Signed-off-by: Ryan Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #142, #146, and #149.
Usage
Same as before
Checklist