Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError in Map Buckets #149

Closed
yyu22 opened this issue Jul 9, 2024 · 2 comments
Closed

KeyError in Map Buckets #149

yyu22 opened this issue Jul 9, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@yyu22
Copy link
Contributor

yyu22 commented Jul 9, 2024

Describe the bug

In map_buckets.py, text_field arg is not specified and the class _MapBuckets has text_field defaults to “text”. This will cause a KeyError if text_field is not "text"

Steps/Code to reproduce bug

    map_buckets = _MapBuckets(
        id_fields=["dataset_id", "doc_id"],
        bucket_field=input_bucket_field,
    )

Expected behavior
set the text_field to the input_text_field

    map_buckets = _MapBuckets(
        id_fields=["dataset_id", "doc_id"],
        bucket_field=input_bucket_field,
        text_field=input_text_field,
    )
@yyu22 yyu22 added the bug Something isn't working label Jul 9, 2024
@ryantwolf ryantwolf self-assigned this Jul 22, 2024
@glam621
Copy link
Collaborator

glam621 commented Aug 19, 2024

Follow up with @yyu22 and @ryantwolf

@yyu22
Copy link
Contributor Author

yyu22 commented Aug 27, 2024

fixed in PR #196

@yyu22 yyu22 closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants