Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow autosizing with detailed performance data inputs for var speed systems #1558

Merged
merged 26 commits into from
Jan 25, 2024
Merged

Allow autosizing with detailed performance data inputs for var speed systems #1558

merged 26 commits into from
Jan 25, 2024

Conversation

yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented Nov 18, 2023 •
edited by shorowit
Loading

Pull Request Description

Address #1557

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@yzhou601 yzhou601 self-assigned this Nov 18, 2023
@yzhou601

This comment was marked as resolved.

Sign in to view
@shorowit shorowit linked an issue Dec 22, 2023 that may be closed by this pull request
Support autosizing with heat pump detailed performance inputs #1557
Closed
@shorowit shorowit added the enhancement New feature or request label Jan 13, 2024
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
2be3174 
…o autosizing_detailed_performance

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Small fix, noticed by @joseph-robertson.
14fd75b
@joseph-robertson joseph-robertson mentioned this pull request Jan 18, 2024
Closed
6 tasks
@yzhou601
Copy link
Collaborator Author

@joseph-robertson I assigned you and Scott to review this PR, lmk if there's any questions.

@yzhou601 yzhou601 requested a review from shorowit January 24, 2024 02:10
@shorowit shorowit marked this pull request as ready for review January 24, 2024 15:36
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
1bffa2c 
…o autosizing_detailed_performance

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
shorowit
shorowit reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few preliminary comments. Haven't dug into the technical implementation much yet.

Changelog.md Outdated Show resolved Hide resolved
docs/source/workflow_inputs.rst Outdated Show resolved Hide resolved
docs/source/workflow_inputs.rst Outdated Show resolved Hide resolved
docs/source/workflow_inputs.rst Outdated Show resolved Hide resolved
docs/source/workflow_inputs.rst Outdated Show resolved Hide resolved
shorowit
shorowit reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, nice work! Ran a few tests and results looked reasonable. Just a few small comments, but it seems close to being merged.

workflow/hpxml_inputs.json Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hpxml_schematron/EPvalidator.xml Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hpxml_defaults.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hpxml_defaults.rb Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/resources/hpxml_defaults.rb Show resolved Hide resolved
joseph-robertson
joseph-robertson approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@joseph-robertson joseph-robertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this implementation in resstock, and it appears to be working as expected.

shorowit
shorowit approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look great. I will merge this in once the CI comes back green. Thanks, @yzhou601!

@shorowit shorowit merged commit 230a717 into master Jan 25, 2024
6 checks passed
@shorowit shorowit deleted the autosizing_detailed_performance branch January 25, 2024 17:37
@joseph-robertson joseph-robertson mentioned this pull request Jan 25, 2024
Merged
13 tasks
@joseph-robertson joseph-robertson mentioned this pull request Feb 8, 2024
Draft
20 tasks
This was referenced Feb 12, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit approved these changes

@joseph-robertson joseph-robertson joseph-robertson approved these changes

Assignees

@yzhou601 yzhou601

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support autosizing with heat pump detailed performance inputs
3 participants
@yzhou601 @shorowit @joseph-robertson