Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove marineanlvrfy task from global-workflow #3314

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ jobs/JGDAS_ATMOS_VERFRAD @EdwardSafford-NOAA
jobs/JGDAS_ENKF_* @RussTreadon-NOAA @CoryMartin-NOAA @CatherineThomas-NOAA
jobs/JGDAS_FIT2OBS @jack-woollen
jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN @guillaumevernieres
jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY @guillaumevernieres
jobs/JGFS_ATMOS_AWIPS_20KM_1P0DEG @GwenChen-NOAA
jobs/JGFS_ATMOS_CYCLONE_GENESIS @JiayiPeng-NOAA
jobs/JGFS_ATMOS_CYCLONE_TRACKER @JiayiPeng-NOAA
Expand Down
1 change: 0 additions & 1 deletion ci/cases/gfsv17/marine3dvar.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ base:
DO_FIT2OBS: "YES"
DO_VERFOZN: "YES"
DO_VERFRAD: "YES"
DO_VRFY_OCEANDA: "NO"
FHMAX_GFS: 240
ACCOUNT: {{ 'HPC_ACCOUNT' | getenv }}
DO_TEST_MODE: "YES"
Expand Down
1 change: 0 additions & 1 deletion ci/cases/gfsv17/marinehyb.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ base:
DO_FIT2OBS: "YES"
DO_VERFOZN: "YES"
DO_VERFRAD: "YES"
DO_VRFY_OCEANDA: "NO"
FHMAX_GFS: 240
ACCOUNT: {{ 'HPC_ACCOUNT' | getenv }}

Expand Down
55 changes: 0 additions & 55 deletions jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY

This file was deleted.

19 changes: 0 additions & 19 deletions jobs/rocoto/ocnanalvrfy.sh

This file was deleted.

3 changes: 0 additions & 3 deletions parm/archive/gdas.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ gdas:
- "logs/{{ cycle_YMDH }}/{{ RUN }}_ocnanalecen.log"
{% endif %}
{% endif %}
{% if DO_VRFY_OCEANDA %}
- "logs/{{ cycle_YMDH }}/{{ RUN }}_ocnanalvrfy.log"
{% endif %}

# Analysis GRIB2 (sub-sampled) data
- "{{ COMIN_ATMOS_GRIB_0p25 | relpath(ROTDIR) }}/{{ head }}pgrb2.0p25.anl"
Expand Down
1 change: 0 additions & 1 deletion parm/config/gfs/config.base
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,6 @@ export DO_CA="YES"
# Verification options
export DO_METP="@DO_METP@" # Run METPLUS jobs - set METPLUS settings in config.metp
export DO_FIT2OBS="YES" # Run fit to observations package
export DO_VRFY_OCEANDA="@DO_VRFY_OCEANDA@" # Run SOCA Ocean and Seaice DA verification tasks

#--online archive of netcdf files for fit2obs verification
export FHMAX_FITS=132
Expand Down
10 changes: 0 additions & 10 deletions parm/config/gfs/config.ocnanalvrfy

This file was deleted.

1 change: 0 additions & 1 deletion parm/config/gfs/yaml/defaults.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ base:
FHMAX_GFS: 120
FHMAX_HF_GFS: 0
FCST_BREAKPOINTS: ""
DO_VRFY_OCEANDA: "NO"
GSI_SOILANAL: "NO"
EUPD_CYC: "gdas"
FHMAX_ENKF_GFS: 12
Expand Down
2 changes: 1 addition & 1 deletion scripts/exglobal_archive_tars.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def main():
'FHOUT_HF_WAV', 'FHMAX_WAV', 'FHMAX_HF_WAV', 'FHMAX_WAV_GFS',
'restart_interval_gdas', 'restart_interval_gfs', 'DO_ARCHTAR',
'DO_AERO_ANL', 'DO_AERO_FCST', 'DO_CA', 'DOIBP_WAV', 'DO_JEDIOCNVAR', 'DOHYBVAR_OCN',
'NMEM_ENS', 'DO_JEDIATMVAR', 'DO_VRFY_OCEANDA', 'FHMAX_FITS', 'waveGRD',
'NMEM_ENS', 'DO_JEDIATMVAR', 'FHMAX_FITS', 'waveGRD',
'IAUFHRS', 'DO_FIT2OBS', 'NET', 'FHOUT_HF_GFS', 'FHMAX_HF_GFS', 'REPLAY_ICS',
'OFFSET_START_HOUR', 'ARCH_EXPDIR', 'EXPDIR', 'ARCH_EXPDIR_FREQ', 'ARCH_HASHES',
'ARCH_DIFFS', 'SDATE', 'EDATE', 'HOMEgfs', 'DO_GEMPAK', 'WAVE_OUT_GRIDS']
Expand Down
5 changes: 0 additions & 5 deletions workflow/applications/gfs_cycled.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ def _get_run_options(self, conf: Configuration) -> Dict[str, Any]:
run_options[run]['do_jediocnvar'] = base.get('DO_JEDIOCNVAR', False)
run_options[run]['do_jedisnowda'] = base.get('DO_JEDISNOWDA', False)
run_options[run]['do_mergensst'] = base.get('DO_MERGENSST', False)
run_options[run]['do_vrfy_oceanda'] = base.get('DO_VRFY_OCEANDA', False)

return run_options

Expand All @@ -70,8 +69,6 @@ def _get_app_configs(self, run):
if options['do_hybvar']:
configs += ['marineanlletkf', 'ocnanalecen']
configs += ['marineanlchkpt', 'marineanlfinal']
if options['do_vrfy_oceanda']:
configs += ['ocnanalvrfy']

if options['do_ocean'] or options['do_ice']:
configs += ['oceanice_products']
Expand Down Expand Up @@ -186,8 +183,6 @@ def get_task_names(self):
if options['do_hybvar']:
task_names[run] += ['marineanlletkf', 'ocnanalecen']
task_names[run] += ['marineanlchkpt', 'marineanlfinal']
if options['do_vrfy_oceanda']:
task_names[run] += ['ocnanalvrfy']

task_names[run] += ['sfcanl', 'analcalc']

Expand Down
24 changes: 0 additions & 24 deletions workflow/rocoto/gfs_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -855,30 +855,6 @@ def marineanlfinal(self):

return task

def ocnanalvrfy(self):

deps = []
dep_dict = {'type': 'task', 'name': f'{self.run}_marineanlfinal'}
deps.append(rocoto.add_dependency(dep_dict))
dependencies = rocoto.create_dependency(dep_condition='and', dep=deps)

resources = self.get_resource('ocnanalvrfy')
task_name = f'{self.run}_ocnanalvrfy'
task_dict = {'task_name': task_name,
'resources': resources,
'dependency': dependencies,
'envars': self.envars,
'cycledef': self.run.replace('enkf', ''),
'command': f'{self.HOMEgfs}/jobs/rocoto/ocnanalvrfy.sh',
'job_name': f'{self.pslot}_{task_name}_@H',
'log': f'{self.rotdir}/logs/@Y@m@d@H/{task_name}.log',
'maxtries': '&MAXTRIES;'
}

task = rocoto.create_task(task_dict)

return task

def fcst(self):

fcst_map = {'forecast-only': self._fcst_forecast_only,
Expand Down