Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove marineanlvrfy task from global-workflow #3314

Merged

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Feb 10, 2025

Description

Removes marineanlvrfy from global-workflow, as this capacity has been set up to run off-line as desired.

Resolves NOAA-EMC/GDASApp#1481

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Clone, build, and fully successful 1.5 cycle run on Hera of C48mx500_3DVarAOWCDA experiment

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to remove reference to DO_VRFY_OCEANDA in parm/archive/gdas.yaml.j2. All other instances of DO_VRFY_OCEANDA appear to be removed.

@AndrewEichmann-NOAA
Copy link
Contributor Author

Also need to remove reference to DO_VRFY_OCEANDA in parm/archive/gdas.yaml.j2. All other instances of DO_VRFY_OCEANDA appear to be removed.

Whoops, removed but not committed

Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @AndrewEichmann-NOAA ! I approve pending approvals from others and any potential CI testing being successful.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@aerorahul aerorahul merged commit f0f9917 into NOAA-EMC:develop Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the verify task from the workflow
4 participants