Skip to content

Commit

Permalink
Fixed the plots codes to prevent potential failure. (#645)
Browse files Browse the repository at this point in the history
  • Loading branch information
SamiraArdani-NOAA authored Jan 8, 2025
1 parent 76641bc commit cb714db
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 3 additions & 1 deletion ush/glwu/lead_average.py
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,7 @@ def plot_lead_average(df: pd.DataFrame, logger: logging.Logger,
else:
handles = []
labels = []
n_mods = 0
for m in range(len(mod_setting_dicts)):
if model_list[m] in model_colors.model_alias:
model_plot_name = (
Expand Down Expand Up @@ -581,9 +582,10 @@ def plot_lead_average(df: pd.DataFrame, logger: logging.Logger,
else:
y_vals_metric_min = np.nanmin(y_vals_metric1)
y_vals_metric_max = np.nanmax(y_vals_metric1)
if m == 0:
if n_mods == 0:
y_mod_min = y_vals_metric_min
y_mod_max = y_vals_metric_max
n_mods+=1
else:
if math.isinf(y_mod_min):
y_mod_min = y_vals_metric_min
Expand Down
5 changes: 4 additions & 1 deletion ush/glwu/time_series.py
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ def plot_time_series(df: pd.DataFrame, logger: logging.Logger,
handles = []
#labels = []
labels = [model_list[0].upper()]
n_mods = 0
for m in range(len(mod_setting_dicts)):
if model_list[m] in model_colors.model_alias:
model_plot_name = (
Expand Down Expand Up @@ -614,10 +615,12 @@ def plot_time_series(df: pd.DataFrame, logger: logging.Logger,
else:
y_vals_metric_min = np.nanmin(y_vals_metric1)
y_vals_metric_max = np.nanmax(y_vals_metric1)
if m == 0:

if n_mods == 0:
y_mod_min = y_vals_metric_min
y_mod_max = y_vals_metric_max
counts = pivot_counts[str(model_list[m])].values
n_mods+=1
else:
y_mod_min = np.nanmin([y_mod_min, y_vals_metric_min])
y_mod_max = np.nanmax([y_mod_max, y_vals_metric_max])
Expand Down

0 comments on commit cb714db

Please sign in to comment.