Fixed the plots codes to prevent potential failure. (#642)

NOAA-EMC · Jan 7, 2025 · 76641bc · 76641bc
1 parent 2288922
commit 76641bc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/ush/nfcens/lead_average.py b/ush/nfcens/lead_average.py
@@ -539,6 +539,7 @@ def plot_lead_average(df: pd.DataFrame, logger: logging.Logger,
     else:
         handles = []
         labels = []
+    n_mods = 0     
     for m in range(len(mod_setting_dicts)):
         if model_list[m] in model_colors.model_alias:
             model_plot_name = (
@@ -581,9 +582,10 @@ def plot_lead_average(df: pd.DataFrame, logger: logging.Logger,
                 else:
                     y_vals_metric_min = np.nanmin(y_vals_metric1)
                     y_vals_metric_max = np.nanmax(y_vals_metric1)
-            if m == 0:
+            if n_mods == 0:
                 y_mod_min = y_vals_metric_min
                 y_mod_max = y_vals_metric_max
+                n_mods+=1
             else:
                 if math.isinf(y_mod_min):
                     y_mod_min = y_vals_metric_min

diff --git a/ush/nfcens/time_series.py b/ush/nfcens/time_series.py
@@ -578,6 +578,7 @@ def plot_time_series(df: pd.DataFrame, logger: logging.Logger,
         labels = [model_list[0].upper()]
     handles = []
     labels = []
+    n_mods = 0
     for m in range(len(mod_setting_dicts)):
         if model_list[m] in model_colors.model_alias:
             model_plot_name = (
@@ -615,10 +616,11 @@ def plot_time_series(df: pd.DataFrame, logger: logging.Logger,
             else:
                 y_vals_metric_min = np.nanmin(y_vals_metric1)
                 y_vals_metric_max = np.nanmax(y_vals_metric1)
-            if m == 0:
+            if n_mods == 0:
                 y_mod_min = y_vals_metric_min
                 y_mod_max = y_vals_metric_max
                 counts = pivot_counts[str(model_list[m])].values
+                n_mods+=1
             else:
                 y_mod_min = np.nanmin([y_mod_min, y_vals_metric_min])
                 y_mod_max = np.nanmax([y_mod_max, y_vals_metric_max])