Capgen in SCM: Bug fix for scheme ordering in non-run phases #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinswales
requested review from
climbfuji,
gold2718,
mwaxmonsky,
peverwhee,
grantfirl and
mkavulich
as code owners
Write something into the initialization phase that makes them depend on each other? For example init call to scheme two depends on something being set in init call to scheme one, etc? If you were to add more than two schemes (e.g., five scheme inits), you increase the changes that they won't be in the correct order. |
peverwhee
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
wow I'm surprised we hadn't run into this issue before! thanks @dustinswales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A python set is used to gather the schemes to call in the non CCPP run phases. However, python sets don't maintain the order, and hence the call order is wrong outside the run phase.
User interface changes?: No
Fixes: #628
Testing:
Expanded var_compatibility_test to have initialization phases and illustrate bug.
Not sure how to test that the order is unchanged?