Capgen in SCM: Multiple instances of local_name in Group Cap #631
Conversation
dustinswales
requested review from
climbfuji,
gold2718,
mwaxmonsky,
peverwhee,
grantfirl and
mkavulich
as code owners
…ustinswales/ccpp-framework into bugfix/local_var_names_in_caps
There was a problem hiding this comment.
I have a suggesting for modifying the test a bit but it looks okay for scalar vars. It would be nice to also implement a DDT test as @peverwhee suggested.
@gold2718 Thanks for the suggestions. I added them to the tests. @peverwhee There are some various tests in the pipeline for DDTs (e.g. #637 #640), albeit stressing different things. I could extend those or add here. Thoughts? |
@dustinswales I vote whatever's easiest for you! |
| # Check if local_name exists in Group. If applicable, Create new | ||
| # variable with uniquie name. There are two instances when new names are |
There was a problem hiding this comment.
| # Check if local_name exists in Group. If applicable, Create new | |
| # variable with uniquie name. There are two instances when new names are | |
| # Check if local_name exists in Group. If applicable, create new | |
| # variable with unique name. There are two instances when new names are |
| @@ -41,6 +41,13 @@ | |||
| kind = kind_phys | |||
| intent = in | |||
| top_at_one = True | |||
| [ scalar_var ] | |||
There was a problem hiding this comment.
This is probably my capgen ignorance showing, but I'm not seeing how these new test variables are checking the new logic. They aren't in DDTs and they aren't duplicate names with different standard names, unless I'm missing something?.
There was a problem hiding this comment.
@mkavulich it's the variable naming in the caps. The test now uses same local_name for 3 different standard_names. To see this, run the var_compatabilty_test and look at the suite cap in ct_build/ccpp, you will see that each instance of scalar_var in the Cap has been renamed to a unique name, scalar_var1, Scalar_var2, and Scalar_var3, respectively.
Description:
Allow for multiple instances of the same local_name being used in the Group cap for two situations:
a) with different standard_names
b) in different DDTs .
User interface changes?: No
Fixes: #629
Testing:
Added to var_compatibility_test to exercise feature.
This PR contains changes included in #630