fix: 🩹 Minor integration test and comment fixes (and testing Blacksmith runners) · Moonsong-Labs/storage-hub@0c2ca84

Unsupported Cargo.lock format, fallback to caching entire file

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/randomness/src/benchmarking.rs#L6

bound is defined in more than one place

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/randomness/src/lib.rs#L198

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/providers/src/benchmarking.rs#L581

using `clone` on type `<T as Config>::ProviderId` which implements the `Copy` trait

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/providers/src/lib.rs#L1557

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/proofs-dealer/src/lib.rs#L757

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/provider-randomness/src/lib.rs#L577

useless conversion to the same type: `std::collections::btree_set::Difference<'_, <<T as pallet_proofs_dealer::Config>::ProvidersPallet as shp_traits::ReadChallengeableProvidersInterface>::ProviderId>`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/provider-randomness/src/lib.rs#L627

called `expect` on `providers_to_mark` after checking its variant with `is_some`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/provider-randomness/src/lib.rs#L560

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/payment-streams/src/lib.rs#L413

using `map_err` over `inspect_err`

Run SKIP_WASM_BUILD=1 env -u RUSTFLAGS cargo clippy --features try-runtime,runtime-benchmarks --locked: pallets/file-system/src/utils.rs#L74

the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 🩹 Minor integration test and comment fixes (and testing Blacksmith runners) #2932

Check lint with clippy

fix: 🩹 Minor integration test and comment fixes (and testing Blacksmith runners) #2932

Jobs

Run details

Annotations

Check lint with clippy

Re-running jobs...